Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/common/origin_util.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/origin_util.cc
diff --git a/content/common/origin_util.cc b/content/common/origin_util.cc
index 2fdc553b5c55aeca570ec772f5ee53573222fe64..cd24228f830e8e6c278f9ca8c9949e7e154175cd 100644
--- a/content/common/origin_util.cc
+++ b/content/common/origin_util.cc
@@ -14,12 +14,12 @@
namespace {
-// This function partially reflects the result from SecurityOrigin::isUnique,
+// This function partially reflects the result from SecurityOrigin::isOpaque,
// not its actual implementation. It takes into account how
-// SecurityOrigin::create might return unique origins for URLs whose schemes are
+// SecurityOrigin::create might return opaque origins for URLs whose schemes are
// included in SchemeRegistry::shouldTreatURLSchemeAsNoAccess.
-bool IsOriginUnique(const url::Origin& origin) {
- return origin.unique() ||
+bool IsOriginOpaque(const url::Origin& origin) {
+ return origin.opaque() ||
base::ContainsValue(url::GetNoAccessSchemes(), origin.scheme());
}
@@ -61,7 +61,7 @@ bool OriginCanAccessServiceWorkers(const GURL& url) {
}
bool IsOriginWhiteListedTrustworthy(const url::Origin& origin) {
- if (IsOriginUnique(origin))
+ if (IsOriginOpaque(origin))
return false;
return base::ContainsValue(GetSecureOrigins(),
@@ -74,7 +74,7 @@ bool IsPotentiallyTrustworthyOrigin(const url::Origin& origin) {
// implementation follows Blink's default behavior but in the renderer it can
// be changed per instance by calls to
// SecurityOrigin::setUniqueOriginIsPotentiallyTrustworthy.
- if (IsOriginUnique(origin))
+ if (IsOriginOpaque(origin))
return false;
if (base::ContainsValue(url::GetSecureSchemes(), origin.scheme()) ||

Powered by Google App Engine
This is Rietveld 408576698