Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 1448dd8939f48fe69578f4ecea6344312c1111fc..cfb052c1ed36c433adbf012f6200989c9e7da2c4 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1824,7 +1824,7 @@ void RenderFrameHostImpl::OnEnforceInsecureRequestPolicy(
void RenderFrameHostImpl::OnUpdateToUniqueOrigin(
bool is_potentially_trustworthy_unique_origin) {
url::Origin origin;
- DCHECK(origin.unique());
+ DCHECK(origin.opaque());
frame_tree_node()->SetCurrentOrigin(origin,
is_potentially_trustworthy_unique_origin);
}
@@ -2429,16 +2429,16 @@ bool RenderFrameHostImpl::CanCommitOrigin(
return true;
}
- // It is safe to commit into a unique origin, regardless of the URL, as it is
+ // It is safe to commit into a opaque origin, regardless of the URL, as it is
// restricted from accessing other origins.
- if (origin.unique())
+ if (origin.opaque())
return true;
// Standard URLs must match the reported origin.
if (url.IsStandard() && !origin.IsSameOriginWith(url::Origin(url)))
return false;
- // A non-unique origin must be a valid URL, which allows us to safely do a
+ // A non-opaque origin must be a valid URL, which allows us to safely do a
// conversion to GURL.
GURL origin_url(origin.Serialize());

Powered by Google App Engine
This is Rietveld 408576698