Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 8c6eb9e245138e3c5fc4be2c347353f0bf5b7186..d969a9bfa5fa413a9042537a1b0145d58642f8ad 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -646,7 +646,7 @@ void PasswordFormManager::ProcessLoginPrompt() {
void PasswordFormManager::ProcessUpdate() {
DCHECK_EQ(FormFetcher::State::NOT_WAITING, form_fetcher_->GetState());
- DCHECK(preferred_match_ || !pending_credentials_.federation_origin.unique());
+ DCHECK(preferred_match_ || !pending_credentials_.federation_origin.opaque());
// If we're doing an Update, we either autofilled correctly and need to
// update the stats, or the user typed in a new password for autofilled
// username, or the user selected one of the non-preferred matches,
@@ -1109,7 +1109,7 @@ const PasswordForm* PasswordFormManager::FindBestMatchForUpdatePassword(
const PasswordForm* PasswordFormManager::FindBestSavedMatch(
const PasswordForm* form) const {
- if (!form->federation_origin.unique())
+ if (!form->federation_origin.opaque())
return nullptr;
auto it = best_matches_.find(form->username_value);
if (it != best_matches_.end())
@@ -1260,7 +1260,7 @@ base::Optional<PasswordForm> PasswordFormManager::UpdatePendingAndGetOldKey(
// complicated, so we skip that, given it influences no users.
update_related_credentials = false;
} else if (observed_form_.new_password_element.empty() &&
- pending_credentials_.federation_origin.unique() &&
+ pending_credentials_.federation_origin.opaque() &&
!IsValidAndroidFacetURI(pending_credentials_.signon_realm) &&
(pending_credentials_.password_element.empty() ||
pending_credentials_.username_element.empty() ||
@@ -1277,7 +1277,7 @@ base::Optional<PasswordForm> PasswordFormManager::UpdatePendingAndGetOldKey(
update_related_credentials = true;
} else {
update_related_credentials =
- pending_credentials_.federation_origin.unique();
+ pending_credentials_.federation_origin.opaque();
}
// If this was a password update, then update all non-best matches entries

Powered by Google App Engine
This is Rietveld 408576698