Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc
diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc
index 63c79bb0a5c1991f5cd2c98e7263994ed10f0f59..2608402015146400d74ca6acf5326015247e8340 100644
--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc
+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc
@@ -70,7 +70,7 @@ void FilterDuplicates(
std::unique_ptr<autofill::PasswordForm>>
credentials;
for (auto& form : *forms) {
- if (!form->federation_origin.unique()) {
+ if (!form->federation_origin.opaque()) {
federated_forms.push_back(std::move(form));
} else {
auto key = std::make_pair(
@@ -164,8 +164,8 @@ void CredentialManagerPendingRequestTask::ProcessForms(
for (auto& form : results) {
// Ensure that the form we're looking at matches the password and
// federation filters provided.
- if (!((form->federation_origin.unique() && include_passwords_) ||
- (!form->federation_origin.unique() &&
+ if (!((form->federation_origin.opaque() && include_passwords_) ||
+ (!form->federation_origin.opaque() &&
federations_.count(form->federation_origin.Serialize())))) {
continue;
}
@@ -199,7 +199,7 @@ void CredentialManagerPendingRequestTask::ProcessForms(
!password_bubble_experiment::ShouldShowAutoSignInPromptFirstRunExperience(
delegate_->client()->GetPrefs())) {
CredentialInfo info(*local_results[0],
- local_results[0]->federation_origin.unique()
+ local_results[0]->federation_origin.opaque()
? CredentialType::CREDENTIAL_TYPE_PASSWORD
: CredentialType::CREDENTIAL_TYPE_FEDERATED);
delegate_->client()->NotifyUserAutoSignin(std::move(local_results),

Powered by Google App Engine
This is Rietveld 408576698