Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Update new uses post-rebase Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_gnome_x.h" 5 #include "chrome/browser/password_manager/native_backend_gnome_x.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 "signon_realm", form.signon_realm.c_str(), 317 "signon_realm", form.signon_realm.c_str(),
318 "preferred", form.preferred, 318 "preferred", form.preferred,
319 "date_created", base::Int64ToString(date_created).c_str(), 319 "date_created", base::Int64ToString(date_created).c_str(),
320 "blacklisted_by_user", form.blacklisted_by_user, 320 "blacklisted_by_user", form.blacklisted_by_user,
321 "type", form.type, 321 "type", form.type,
322 "times_used", form.times_used, 322 "times_used", form.times_used,
323 "scheme", form.scheme, 323 "scheme", form.scheme,
324 "date_synced", base::Int64ToString(date_synced).c_str(), 324 "date_synced", base::Int64ToString(date_synced).c_str(),
325 "display_name", UTF16ToUTF8(form.display_name).c_str(), 325 "display_name", UTF16ToUTF8(form.display_name).c_str(),
326 "avatar_url", form.icon_url.spec().c_str(), 326 "avatar_url", form.icon_url.spec().c_str(),
327 // We serialize unique origins as "", in order to make other systems that 327 // We serialize opaque origins as "", in order to make other systems that
328 // read from the login database happy. https://crbug.com/591310 328 // read from the login database happy. https://crbug.com/591310
329 "federation_url", form.federation_origin.unique() 329 "federation_url", form.federation_origin.opaque()
330 ? "" 330 ? ""
331 : form.federation_origin.Serialize().c_str(), 331 : form.federation_origin.Serialize().c_str(),
332 "should_skip_zero_click", form.skip_zero_click, 332 "should_skip_zero_click", form.skip_zero_click,
333 "generation_upload_status", form.generation_upload_status, 333 "generation_upload_status", form.generation_upload_status,
334 "form_data", form_data.c_str(), 334 "form_data", form_data.c_str(),
335 "application", app_string, 335 "application", app_string,
336 nullptr); 336 nullptr);
337 // clang-format on 337 // clang-format on
338 } 338 }
339 339
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 std::vector<std::unique_ptr<PasswordForm>> forms; 803 std::vector<std::unique_ptr<PasswordForm>> forms;
804 if (!GetLoginsBetween(get_begin, get_end, date_to_compare, &forms)) 804 if (!GetLoginsBetween(get_begin, get_end, date_to_compare, &forms))
805 return false; 805 return false;
806 806
807 for (size_t i = 0; i < forms.size(); ++i) { 807 for (size_t i = 0; i < forms.size(); ++i) {
808 if (!RemoveLogin(*forms[i], changes)) 808 if (!RemoveLogin(*forms[i], changes))
809 return false; 809 return false;
810 } 810 }
811 return true; 811 return true;
812 } 812 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698