Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Side by Side Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_libsecret.h" 5 #include "chrome/browser/password_manager/native_backend_libsecret.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <libsecret/secret.h> 10 #include <libsecret/secret.h>
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 "signon_realm", form.signon_realm.c_str(), 368 "signon_realm", form.signon_realm.c_str(),
369 "preferred", form.preferred, 369 "preferred", form.preferred,
370 "date_created", base::Int64ToString(date_created).c_str(), 370 "date_created", base::Int64ToString(date_created).c_str(),
371 "blacklisted_by_user", form.blacklisted_by_user, 371 "blacklisted_by_user", form.blacklisted_by_user,
372 "type", form.type, 372 "type", form.type,
373 "times_used", form.times_used, 373 "times_used", form.times_used,
374 "scheme", form.scheme, 374 "scheme", form.scheme,
375 "date_synced", base::Int64ToString(date_synced).c_str(), 375 "date_synced", base::Int64ToString(date_synced).c_str(),
376 "display_name", UTF16ToUTF8(form.display_name).c_str(), 376 "display_name", UTF16ToUTF8(form.display_name).c_str(),
377 "avatar_url", form.icon_url.spec().c_str(), 377 "avatar_url", form.icon_url.spec().c_str(),
378 // We serialize unique origins as "", in order to make other systems that 378 // We serialize opaque origins as "", in order to make other systems that
379 // read from the login database happy. https://crbug.com/591310 379 // read from the login database happy. https://crbug.com/591310
380 "federation_url", form.federation_origin.unique() 380 "federation_url", form.federation_origin.opaque()
381 ? "" 381 ? ""
382 : form.federation_origin.Serialize().c_str(), 382 : form.federation_origin.Serialize().c_str(),
383 "should_skip_zero_click", form.skip_zero_click, 383 "should_skip_zero_click", form.skip_zero_click,
384 "generation_upload_status", form.generation_upload_status, 384 "generation_upload_status", form.generation_upload_status,
385 "form_data", form_data.c_str(), 385 "form_data", form_data.c_str(),
386 "application", app_string_.c_str(), 386 "application", app_string_.c_str(),
387 nullptr); 387 nullptr);
388 // clang-format on 388 // clang-format on
389 389
390 if (error) { 390 if (error) {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 GURL(lookup_form->signon_realm))); 573 GURL(lookup_form->signon_realm)));
574 UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering", 574 UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
575 allow_psl_match 575 allow_psl_match
576 ? psl_domain_match_metric 576 ? psl_domain_match_metric
577 : password_manager::PSL_DOMAIN_MATCH_NOT_USED, 577 : password_manager::PSL_DOMAIN_MATCH_NOT_USED,
578 password_manager::PSL_DOMAIN_MATCH_COUNT); 578 password_manager::PSL_DOMAIN_MATCH_COUNT);
579 } 579 }
580 g_list_free(found); 580 g_list_free(found);
581 return forms; 581 return forms;
582 } 582 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698