Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 2716583003: Rename Origin.unique() to opaque().
Patch Set: Mac fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/native_backend_gnome_x.h" 5 #include "chrome/browser/password_manager/native_backend_gnome_x.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 "signon_realm", form.signon_realm.c_str(), 312 "signon_realm", form.signon_realm.c_str(),
313 "preferred", form.preferred, 313 "preferred", form.preferred,
314 "date_created", base::Int64ToString(date_created).c_str(), 314 "date_created", base::Int64ToString(date_created).c_str(),
315 "blacklisted_by_user", form.blacklisted_by_user, 315 "blacklisted_by_user", form.blacklisted_by_user,
316 "type", form.type, 316 "type", form.type,
317 "times_used", form.times_used, 317 "times_used", form.times_used,
318 "scheme", form.scheme, 318 "scheme", form.scheme,
319 "date_synced", base::Int64ToString(date_synced).c_str(), 319 "date_synced", base::Int64ToString(date_synced).c_str(),
320 "display_name", UTF16ToUTF8(form.display_name).c_str(), 320 "display_name", UTF16ToUTF8(form.display_name).c_str(),
321 "avatar_url", form.icon_url.spec().c_str(), 321 "avatar_url", form.icon_url.spec().c_str(),
322 // We serialize unique origins as "", in order to make other systems that 322 // We serialize opaque origins as "", in order to make other systems that
323 // read from the login database happy. https://crbug.com/591310 323 // read from the login database happy. https://crbug.com/591310
324 "federation_url", form.federation_origin.unique() 324 "federation_url", form.federation_origin.opaque()
325 ? "" 325 ? ""
326 : form.federation_origin.Serialize().c_str(), 326 : form.federation_origin.Serialize().c_str(),
327 "should_skip_zero_click", form.skip_zero_click, 327 "should_skip_zero_click", form.skip_zero_click,
328 "generation_upload_status", form.generation_upload_status, 328 "generation_upload_status", form.generation_upload_status,
329 "form_data", form_data.c_str(), 329 "form_data", form_data.c_str(),
330 "application", app_string, 330 "application", app_string,
331 nullptr); 331 nullptr);
332 // clang-format on 332 // clang-format on
333 } 333 }
334 334
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 std::vector<std::unique_ptr<PasswordForm>> forms; 779 std::vector<std::unique_ptr<PasswordForm>> forms;
780 if (!GetLoginsBetween(get_begin, get_end, date_to_compare, &forms)) 780 if (!GetLoginsBetween(get_begin, get_end, date_to_compare, &forms))
781 return false; 781 return false;
782 782
783 for (size_t i = 0; i < forms.size(); ++i) { 783 for (size_t i = 0; i < forms.size(); ++i) {
784 if (!RemoveLogin(*forms[i], changes)) 784 if (!RemoveLogin(*forms[i], changes))
785 return false; 785 return false;
786 } 786 }
787 return true; 787 return true;
788 } 788 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698