third_party/WebKit/LayoutTests/fast/block/large-border-abspos.html - Issue 2716583002: Avoid negative content box sizes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/large-border-abspos.html

Issue 2716583002: Avoid negative content box sizes. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!-- The left offset here is just to push the huge thing out of view, so that a

	3 human (yes, YOU!) can see the test results. -->

	4 <div style="position:absolute; left:100%; border-width:1234567890px; border-styl e:solid;">
	mstensho (USE GERRIT) 2017/02/23 13:35:09 This test is valid, but it would also pass prior t This test is valid, but it would also pass prior to this CL, but not prior to https://codereview.chromium.org/2640143005 (support for sub-pixel borders), which landed while I was working on this CL. The test is still worth keeping, I'd say. eae 2017/02/23 15:54:37 Agreed! Show quoted text On 2017/02/23 13:35:09, mstensho wrote: > This test is valid, but it would also pass prior to this CL, but not prior to > https://codereview.chromium.org/2640143005 (support for sub-pixel borders), > which landed while I was working on this CL. The test is still worth keeping, > I'd say. Agreed!
	5 <div id="abspos" style="position:absolute; left:0; top:0; right:0; bottom:0; "></div>

	6 </div>

	7 <script src="../../resources/testharness.js"></script>

	8 <script src="../../resources/testharnessreport.js"></script>

	9 <script>

	10 test(() => {

	11 assert_equals(document.getElementById("abspos").offsetWidth, 0);

	12 assert_equals(document.getElementById("abspos").offsetHeight, 0);

	13 }, "Sizes should never become negative");

	14 </script>

OLD	NEW