Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2716573002: closure conversion: Do not set Context.parent if the value is `null` (Closed)

Created:
3 years, 10 months ago by karlklose
Modified:
3 years, 9 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

closure conversion: Do not set Context.parent if the value is `null` R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/5df53955597c285547deec6ecb4dd0672a0a740a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M pkg/kernel/lib/transformations/closure/rewriter.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/kernel/testcases/closures/capture_closure.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/capture_this.dart.expect View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures/catch.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/closure_in_constructor.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/closure_in_initializer.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/closure_in_initializer_closure.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/closures.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/for_in_closure.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/for_loop.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/for_variable_capture_test.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/named_closure.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/non_void_context.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/type_variables.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/testcases/closures/uncaptured_for_in_loop.dart.expect View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
karlklose
3 years, 10 months ago (2017-02-23 08:27:01 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 10 months ago (2017-02-24 09:47:40 UTC) #3
karlklose
3 years, 9 months ago (2017-02-28 10:23:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5df53955597c285547deec6ecb4dd0672a0a740a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698