Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: cc/surfaces/surface_manager.cc

Issue 2716553004: Add temporary reference ownership to SurfaceManager. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_manager_ref_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index 8bb0cba6eb9fcdde8d4b08bb471e7c1c6d402074..e73e814e10516125dd8fe19441da2fd4a6f1f188 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -136,6 +136,20 @@ void SurfaceManager::RegisterFrameSinkId(const FrameSinkId& frame_sink_id) {
void SurfaceManager::InvalidateFrameSinkId(const FrameSinkId& frame_sink_id) {
valid_frame_sink_ids_.erase(frame_sink_id);
+
+ if (using_surface_references()) {
+ // Remove any temporary references owned by |frame_sink_id|.
+ std::vector<SurfaceId> temp_refs_to_clear;
+ for (auto& map_entry : temporary_references_) {
+ base::Optional<FrameSinkId>& owner = map_entry.second;
+ if (owner.has_value() && owner.value() == frame_sink_id)
+ temp_refs_to_clear.push_back(map_entry.first);
+ }
+
+ for (auto& surface_id : temp_refs_to_clear)
+ RemoveTemporaryReference(surface_id, false);
+ }
+
GarbageCollectSurfaces();
}
@@ -163,6 +177,27 @@ void SurfaceManager::RemoveSurfaceReferences(
GarbageCollectSurfaces();
}
+void SurfaceManager::AssignTemporaryReference(const SurfaceId& surface_id,
+ const FrameSinkId& owner) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK_EQ(lifetime_type_, LifetimeType::REFERENCES);
+
+ if (!HasTemporaryReference(surface_id))
+ return;
+
+ temporary_references_[surface_id] = owner;
+}
+
+void SurfaceManager::DropTemporaryReference(const SurfaceId& surface_id) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK_EQ(lifetime_type_, LifetimeType::REFERENCES);
+
+ if (!HasTemporaryReference(surface_id))
+ return;
+
+ RemoveTemporaryReference(surface_id, false);
+}
+
void SurfaceManager::GarbageCollectSurfaces() {
if (surfaces_to_destroy_.empty())
return;
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/surfaces/surface_manager_ref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698