Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 271653003: Scrub deprecated Skia APIs. (Closed)

Created:
6 years, 7 months ago by f(malita)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, fischman+watch_chromium.org, tfarina, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, rsesek+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Scrub deprecated Skia APIs. Refactor clients using equivalent non-deprecated methods. R=reed@google.com,enne@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269497

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -72 lines) Patch
M cc/output/software_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/fake_desktop_media_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositing_iosurface_transformer_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 4 chunks +6 lines, -6 lines 1 comment Download
M media/filters/skcanvas_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 chunk +1 line, -1 line 1 comment Download
M ui/gfx/canvas.h View 1 chunk +0 lines, -12 lines 1 comment Download
M ui/gfx/canvas.cc View 6 chunks +6 lines, -33 lines 0 comments Download
M ui/gfx/color_analysis_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/proportional_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/image_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
f(malita)
https://codereview.chromium.org/271653003/diff/1/ui/gfx/canvas.h File ui/gfx/canvas.h (left): https://codereview.chromium.org/271653003/diff/1/ui/gfx/canvas.h#oldcode448 ui/gfx/canvas.h:448: // Builds mip map for returned image rep if ...
6 years, 7 months ago (2014-05-07 17:09:46 UTC) #1
enne (OOO)
cc rslgtm
6 years, 7 months ago (2014-05-07 17:14:30 UTC) #2
reed1
lgtm -- my thoughts about colortype can happen in a later CL https://codereview.chromium.org/271653003/diff/1/chrome/browser/ui/app_list/fast_show_pickler.cc File chrome/browser/ui/app_list/fast_show_pickler.cc ...
6 years, 7 months ago (2014-05-07 18:06:22 UTC) #3
sky
LGTM
6 years, 7 months ago (2014-05-07 20:09:00 UTC) #4
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-05-07 21:16:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/271653003/1
6 years, 7 months ago (2014-05-07 21:20:29 UTC) #6
f(malita)
+ scherkus for media/ & piman for content/common/gpu/
6 years, 7 months ago (2014-05-07 21:31:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 21:45:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 21:58:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 22:01:53 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-07 22:01:53 UTC) #11
scherkus (not reviewing)
media lgtm
6 years, 7 months ago (2014-05-07 23:33:24 UTC) #12
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-05-08 22:38:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/271653003/1
6 years, 7 months ago (2014-05-08 22:47:50 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 23:40:23 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 23:58:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66646)
6 years, 7 months ago (2014-05-08 23:58:53 UTC) #17
piman
lgtm
6 years, 7 months ago (2014-05-09 00:59:52 UTC) #18
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-05-09 01:00:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/271653003/1
6 years, 7 months ago (2014-05-09 01:05:01 UTC) #20
f(malita)
The CQ bit was unchecked by fmalita@chromium.org
6 years, 7 months ago (2014-05-09 13:26:50 UTC) #21
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-05-09 13:27:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/271653003/1
6 years, 7 months ago (2014-05-09 13:30:12 UTC) #23
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:48:05 UTC) #24
Message was sent while issue was closed.
Change committed as 269497

Powered by Google App Engine
This is Rietveld 408576698