Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4658)

Unified Diff: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc

Issue 271653002: Rewrote WebRTC browser tests to not use peerconnection_server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit fixes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
index 280a8c05f07e15974b0aae5a8f9dacb440731b11..edb42b04c4fe7e504bdb259b59144c7d71f3edc9 100644
--- a/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc
@@ -106,10 +106,7 @@ static const struct VideoQualityTestConfig {
// * zxing (see the CPP version at https://code.google.com/p/zxing)
// * ffmpeg 0.11.1 or compatible version (see http://www.ffmpeg.org)
//
-// The test case will launch a custom binary (peerconnection_server) which will
-// allow two WebRTC clients to find each other.
-//
-// The test also runs several other custom binaries - rgba_to_i420 converter and
+// The test runs several custom binaries - rgba_to_i420 converter and
// frame_analyzer. Both tools can be found under third_party/webrtc/tools. The
// test also runs a stand alone Python implementation of a WebSocket server
// (pywebsocket) and a barcode_decoder script.
@@ -123,7 +120,6 @@ class WebRtcVideoQualityBrowserTest : public WebRtcTestBase,
}
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
- test::PeerConnectionServerRunner::KillAllPeerConnectionServers();
DetectErrorsInJavaScript(); // Look for errors in our rather complex js.
}
@@ -298,7 +294,6 @@ class WebRtcVideoQualityBrowserTest : public WebRtcTestBase,
}
protected:
- test::PeerConnectionServerRunner peerconnection_server_;
VideoQualityTestConfig test_config_;
private:
@@ -339,7 +334,6 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
ASSERT_TRUE(HasAllRequiredResources());
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
ASSERT_TRUE(StartPyWebSocketServer());
- ASSERT_TRUE(peerconnection_server_.Start());
content::WebContents* left_tab =
OpenPageAndGetUserMediaInNewTabWithConstraints(
@@ -350,7 +344,10 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
embedded_test_server()->GetURL(test_config_.capture_page),
test_config_.constraints);
- EstablishCall(left_tab, right_tab);
+ SetupPeerconnectionWithLocalStream(left_tab);
+ SetupPeerconnectionWithLocalStream(right_tab);
+
+ NegotiateCall(left_tab, right_tab);
// Poll slower here to avoid flooding the log with messages: capturing and
// sending frames take quite a bit of time.
@@ -361,8 +358,6 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
polling_interval_msec));
HangUp(left_tab);
- WaitUntilHangupVerified(left_tab);
- WaitUntilHangupVerified(right_tab);
EXPECT_TRUE(test::PollingWaitUntil(
"haveMoreFramesToSend()", "no-more-frames", right_tab,
@@ -371,7 +366,6 @@ IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
// Shut everything down to avoid having the javascript race with the analysis
// tools. For instance, dont have console log printouts interleave with the
// RESULT lines from the analysis tools (crbug.com/323200).
- ASSERT_TRUE(peerconnection_server_.Stop());
ASSERT_TRUE(ShutdownPyWebSocketServer());
chrome::CloseWebContents(browser(), left_tab, false);
« no previous file with comments | « chrome/browser/media/chrome_webrtc_typing_detection_browsertest.cc ('k') | chrome/browser/media/webrtc_browsertest_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698