Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: build/all.gyp

Issue 271653002: Rewrote WebRTC browser tests to not use peerconnection_server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/all.gyp
diff --git a/build/all.gyp b/build/all.gyp
index cd985c56881760ffb32b871fa9b38ed87543d6d7..8ac6f9c10ed2cc9cd0c2e4e59a93d3047dd8c53e 100644
--- a/build/all.gyp
+++ b/build/all.gyp
@@ -604,11 +604,10 @@
'target_name': 'chromium_builder_webrtc',
'type': 'none',
'dependencies': [
- 'chromium_builder_qa', # needed for perf pyauto tests
+ 'chromium_builder_qa', # TODO(phoglund): not sure if needed?
kjellander_chromium 2014/05/08 09:11:50 It's just a convenient target that is used by othe
phoglund_chromium 2014/05/08 13:27:42 All right, I'll write that in the comment then (as
tommi (sloooow) - chröme 2014/05/08 13:32:46 could you run a try job without it in?
'../chrome/chrome.gyp:browser_tests',
'../content/content_shell_and_tests.gyp:content_browsertests',
'../content/content_shell_and_tests.gyp:content_unittests',
- '../third_party/libjingle/libjingle.gyp:peerconnection_server',
'../third_party/webrtc/tools/tools.gyp:frame_analyzer',
'../third_party/webrtc/tools/tools.gyp:rgba_to_i420_converter',
],

Powered by Google App Engine
This is Rietveld 408576698