Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/PRESUBMIT.py

Issue 27165006: First pass performance try bot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | tools/bisect-perf-regression.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/PRESUBMIT.py
diff --git a/tools/PRESUBMIT.py b/tools/PRESUBMIT.py
index 01572314c06b789f75696cab12e3b91a9cb309fe..b6710568e20e529dacbfb6b26bfcebb2dbb463fa 100644
--- a/tools/PRESUBMIT.py
+++ b/tools/PRESUBMIT.py
@@ -9,14 +9,16 @@ details on the presubmit API built into gcl.
"""
import imp
+import os
-def _ExamineBisectConfigFile(input_api, output_api):
+def _ExamineConfigFiles(input_api):
for f in input_api.AffectedFiles():
- if not f.LocalPath().endswith('run-bisect-perf-regression.cfg'):
+ if (not f.LocalPath().endswith('run-bisect-perf-regression.cfg') and
+ not f.LocalPath().endswith('run-perf-test.cfg')):
continue
try:
- cfg_file = imp.load_source('config', 'run-bisect-perf-regression.cfg')
+ cfg_file = imp.load_source('config', os.path.basename(f.LocalPath()))
for k, v in cfg_file.config.iteritems():
if v:
@@ -27,7 +29,7 @@ def _ExamineBisectConfigFile(input_api, output_api):
return None
def _CheckNoChangesToBisectConfigFile(input_api, output_api):
- results = _ExamineBisectConfigFile(input_api, output_api)
+ results = _ExamineConfigFiles(input_api)
if results:
return [output_api.PresubmitError(
'The bisection config file should only contain a config dict with '
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | tools/bisect-perf-regression.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698