Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: content/browser/webui/web_ui_impl.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webui/web_ui_impl.cc
diff --git a/content/browser/webui/web_ui_impl.cc b/content/browser/webui/web_ui_impl.cc
index 5e080a65aa73081aeb67164b71a9893cbcede584..c024bc82b8b20a0ef06f6a5aa0061f25bdf23437 100644
--- a/content/browser/webui/web_ui_impl.cc
+++ b/content/browser/webui/web_ui_impl.cc
@@ -39,7 +39,8 @@ class WebUIImpl::MainFrameNavigationObserver : public WebContentsObserver {
void DidFinishNavigation(NavigationHandle* navigation_handle) override {
// Only disallow JavaScript on cross-document navigations in the main frame.
if (!navigation_handle->IsInMainFrame() ||
- !navigation_handle->HasCommitted() || navigation_handle->IsSamePage()) {
+ !navigation_handle->HasCommitted() ||
+ navigation_handle->IsSameDocument()) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698