Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc b/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
index 822109c1baf2817794bb6ebaa3bba9d5e5e14bb7..0621614d756ae712fe63672a3944a9d7439452a3 100644
--- a/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
+++ b/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
@@ -160,8 +160,10 @@ void ChromeOmniboxNavigationObserver::Observe(
void ChromeOmniboxNavigationObserver::DidStartNavigation(
content::NavigationHandle* navigation_handle) {
- if (!navigation_handle->IsInMainFrame() || navigation_handle->IsSamePage())
+ if (!navigation_handle->IsInMainFrame() ||
+ navigation_handle->IsSameDocument()) {
return;
+ }
if (load_state_ == LOAD_NOT_SEEN) {
load_state_ = LOAD_PENDING;
@@ -174,10 +176,9 @@ void ChromeOmniboxNavigationObserver::DidStartNavigation(
void ChromeOmniboxNavigationObserver::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
- if ((load_state_ != LOAD_COMMITTED) &&
- navigation_handle->IsErrorPage() &&
+ if ((load_state_ != LOAD_COMMITTED) && navigation_handle->IsErrorPage() &&
navigation_handle->IsInMainFrame() &&
- !navigation_handle->IsSamePage())
+ !navigation_handle->IsSameDocument())
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698