Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 36463cff7cd8c2d1c1b8b966e0d5fe81391bd6ca..726f25f9b08860ac1725368595806c6207059fe0 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -343,7 +343,7 @@ void AppBannerManager::SendBannerPromptRequest() {
}
void AppBannerManager::DidStartNavigation(content::NavigationHandle* handle) {
- if (!handle->IsInMainFrame() || handle->IsSamePage())
+ if (!handle->IsInMainFrame() || handle->IsSameDocument())
return;
load_finished_ = false;
@@ -358,7 +358,7 @@ void AppBannerManager::DidStartNavigation(content::NavigationHandle* handle) {
void AppBannerManager::DidFinishNavigation(content::NavigationHandle* handle) {
if (handle->IsInMainFrame() && handle->HasCommitted() &&
- !handle->IsSamePage()) {
+ !handle->IsSameDocument()) {
ResetCurrentPageData();
if (is_active_)
Stop();

Powered by Google App Engine
This is Rietveld 408576698