Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4158)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2716493004: Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index e8c5b4d7e015c9044bae60339599c0c1a8e57b62..e53a3059481c203bbf7d58fb05e42fa984e13d17 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -189,11 +189,12 @@ bool RecentTabHelper::EnsureInitialized() {
void RecentTabHelper::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
if (!navigation_handle->IsInMainFrame() ||
- !navigation_handle->HasCommitted() || navigation_handle->IsSamePage()) {
+ !navigation_handle->HasCommitted() ||
+ navigation_handle->IsSameDocument()) {
DVLOG_IF(1, navigation_handle->IsInMainFrame())
<< "Main frame navigation ignored (reasons: "
<< !navigation_handle->HasCommitted() << ", "
- << navigation_handle->IsSamePage()
+ << navigation_handle->IsSameDocument()
<< ") to: " << web_contents()->GetLastCommittedURL().spec();
return;
}
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698