Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2716493002: Add a variations parameter to control WebAPK renderer launching. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 360b52624cac92b4f4021ac8f1d2fbdeca45270c..20260d41f1e49486631e66c8396bac8a4def4824 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -30,6 +30,14 @@ import org.chromium.webapk.lib.client.WebApkServiceConnectionManager;
public class WebApkActivity extends WebappActivity {
/** Manages whether to check update for the WebAPK, and starts update check if needed. */
private WebApkUpdateManager mUpdateManager;
+ /** Indicates whether to launch WebAPK renderer or not. */
dominickn 2017/02/23 00:17:28 Nit: newline above this.
F 2017/02/23 01:15:42 Done.
+ private boolean mCanLaunchWebApkRenderer;
+
+ public WebApkActivity() {
+ super();
+
+ mCanLaunchWebApkRenderer = ChromeWebApkHost.canLaunchWebApkRenderer();
+ }
@Override
protected void onNewIntent(Intent intent) {
@@ -155,14 +163,14 @@ public class WebApkActivity extends WebappActivity {
// its AndroidManifest.xml. We set {@link ChildProcessCreationParams} for WebAPK's renderer
// process so the {@link ChildProcessLauncher} knows which application's renderer
// service to connect.
- initializeChildProcessCreationParams(true);
+ initializeChildProcessCreationParams(mCanLaunchWebApkRenderer);
}
@Override
protected void initializeChildProcessCreationParams() {
// TODO(hanxi): crbug.com/611842. Investigates whether this function works for multiple
// windows or with --site-per-process enabled.
- initializeChildProcessCreationParams(true);
+ initializeChildProcessCreationParams(mCanLaunchWebApkRenderer);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698