Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/android/webapk/chrome_webapk_host.cc

Issue 2716493002: Add a variations parameter to control WebAPK renderer launching. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/webapk/chrome_webapk_host.h" 5 #include "chrome/browser/android/webapk/chrome_webapk_host.h"
6 6
7 #include "chrome/browser/android/chrome_feature_list.h" 7 #include "chrome/browser/android/chrome_feature_list.h"
8 #include "components/variations/variations_associated_data.h" 8 #include "components/variations/variations_associated_data.h"
9 #include "jni/ChromeWebApkHost_jni.h" 9 #include "jni/ChromeWebApkHost_jni.h"
10 10
11 namespace { 11 namespace {
12 12
13 // Variations flag to enable installing WebAPKs using Google Play. 13 // Variations flag to enable installing WebAPKs using Google Play.
14 const char* kPlayInstall = "play_install"; 14 const char* kPlayInstall = "play_install";
15 15
16 // Variations flag to enable launching WebAPK renderers.
17 const char* kWebApkRenderer = "webapk_renderer";
dominickn 2017/02/23 00:17:28 It's not clear what true and false mean here. Can
F 2017/02/23 01:15:43 Done.
18
16 } // anonymous namespace 19 } // anonymous namespace
17 20
18 // static 21 // static
19 bool ChromeWebApkHost::Register(JNIEnv* env) { 22 bool ChromeWebApkHost::Register(JNIEnv* env) {
20 return RegisterNativesImpl(env); 23 return RegisterNativesImpl(env);
21 } 24 }
22 25
23 // static 26 // static
24 bool ChromeWebApkHost::CanInstallWebApk() { 27 bool ChromeWebApkHost::CanInstallWebApk() {
25 JNIEnv* env = base::android::AttachCurrentThread(); 28 JNIEnv* env = base::android::AttachCurrentThread();
26 return Java_ChromeWebApkHost_canInstallWebApk(env); 29 return Java_ChromeWebApkHost_canInstallWebApk(env);
27 } 30 }
28 31
29 // static 32 // static
30 jboolean CanUseGooglePlayToInstallWebApk( 33 jboolean CanUseGooglePlayToInstallWebApk(
31 JNIEnv* env, 34 JNIEnv* env,
32 const base::android::JavaParamRef<jclass>& clazz) { 35 const base::android::JavaParamRef<jclass>& clazz) {
33 return variations::GetVariationParamValueByFeature( 36 return variations::GetVariationParamValueByFeature(
34 chrome::android::kImprovedA2HS, kPlayInstall) == "true"; 37 chrome::android::kImprovedA2HS, kPlayInstall) == "true";
35 } 38 }
36 39
37 // static 40 // static
41 jboolean CanLaunchWebApkRenderer(
dominickn 2017/02/23 00:17:28 CanLaunchRendererInWebApkProcess ?
F 2017/02/23 01:15:43 Done.
42 JNIEnv* env,
43 const base::android::JavaParamRef<jclass>& clazz) {
44 return variations::GetVariationParamValueByFeature(
45 chrome::android::kImprovedA2HS, kWebApkRenderer) == "true";
46 }
47
48 // static
38 jboolean CanInstallFromUnknownSources( 49 jboolean CanInstallFromUnknownSources(
39 JNIEnv* env, 50 JNIEnv* env,
40 const base::android::JavaParamRef<jclass>& clazz) { 51 const base::android::JavaParamRef<jclass>& clazz) {
41 return base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine( 52 return base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
42 chrome::android::kImprovedA2HS.name, 53 chrome::android::kImprovedA2HS.name,
43 base::FeatureList::OVERRIDE_ENABLE_FEATURE); 54 base::FeatureList::OVERRIDE_ENABLE_FEATURE);
44 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698