Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2716453006: Add error for mixins defining conflicting private names (issue 28809) (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add error for mixins defining conflicting private names (issue 28809) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/12b6f249f35f14a28e1c454a32505d0659630ccf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +10 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +75 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-24 22:59:19 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2716453006/diff/1/pkg/analyzer/lib/src/error/codes.dart File pkg/analyzer/lib/src/error/codes.dart (right): https://codereview.chromium.org/2716453006/diff/1/pkg/analyzer/lib/src/error/codes.dart#newcode2049 pkg/analyzer/lib/src/error/codes.dart:2049: * It is an error for a mixin ...
3 years, 10 months ago (2017-02-24 23:03:51 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2716453006/diff/1/pkg/analyzer/lib/src/error/codes.dart File pkg/analyzer/lib/src/error/codes.dart (right): https://codereview.chromium.org/2716453006/diff/1/pkg/analyzer/lib/src/error/codes.dart#newcode2049 pkg/analyzer/lib/src/error/codes.dart:2049: * It is an error for a mixin to ...
3 years, 10 months ago (2017-02-24 23:07:21 UTC) #4
Brian Wilkerson
3 years, 10 months ago (2017-02-25 15:28:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
12b6f249f35f14a28e1c454a32505d0659630ccf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698