Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3354)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2716453005: Aura Overlay Scrollbars appear when mouse hovers over scroller edge (Closed)
Patch Set: bokan comments addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 5d91fc703c8436df4fa9f432099b4a3e1b2039a9..7c338a4f8ec0e094768027c90fdfaa58fddb2515 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -1395,25 +1395,29 @@ const gfx::Rect LayerTreeImpl::ViewportRectForTilePriority() const {
std::unique_ptr<ScrollbarAnimationController>
LayerTreeImpl::CreateScrollbarAnimationController(int scroll_layer_id) {
- DCHECK(!settings().scrollbar_fade_delay.is_zero());
- DCHECK(!settings().scrollbar_fade_duration.is_zero());
- base::TimeDelta delay = settings().scrollbar_fade_delay;
- base::TimeDelta resize_delay = settings().scrollbar_fade_resize_delay;
- base::TimeDelta fade_duration = settings().scrollbar_fade_duration;
+ DCHECK(!settings().scrollbar_fade_out_delay.is_zero());
+ DCHECK(!settings().scrollbar_fade_out_duration.is_zero());
+ base::TimeDelta fade_out_delay = settings().scrollbar_fade_out_delay;
+ base::TimeDelta fade_out_resize_delay =
+ settings().scrollbar_fade_out_resize_delay;
+ base::TimeDelta fade_out_duration = settings().scrollbar_fade_out_duration;
switch (settings().scrollbar_animator) {
case LayerTreeSettings::ANDROID_OVERLAY: {
return ScrollbarAnimationController::
CreateScrollbarAnimationControllerAndroid(
- scroll_layer_id, layer_tree_host_impl_, delay, resize_delay,
- fade_duration);
+ scroll_layer_id, layer_tree_host_impl_, fade_out_delay,
+ fade_out_resize_delay, fade_out_duration);
}
case LayerTreeSettings::AURA_OVERLAY: {
+ DCHECK(!settings().scrollbar_fade_in_delay.is_zero());
+ base::TimeDelta fade_in_delay = settings().scrollbar_fade_in_delay;
base::TimeDelta thinning_duration =
settings().scrollbar_thinning_duration;
return ScrollbarAnimationController::
CreateScrollbarAnimationControllerAuraOverlay(
- scroll_layer_id, layer_tree_host_impl_, delay, resize_delay,
- fade_duration, thinning_duration);
+ scroll_layer_id, layer_tree_host_impl_, fade_in_delay,
+ fade_out_delay, fade_out_resize_delay, fade_out_duration,
+ thinning_duration);
}
case LayerTreeSettings::NO_ANIMATOR:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698