ui/native_theme/overlay_scrollbar_constants_aura.h - Issue 2716453005: Aura Overlay Scrollbars appear when mouse hovers over scroller edge

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/native_theme/overlay_scrollbar_constants_aura.h

Issue 2716453005: Aura Overlay Scrollbars appear when mouse hovers over scroller edge (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/input/scrollbar_animation_controller_unittest.cc ('K') | « content/renderer/gpu/render_widget_compositor.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_	5 #ifndef UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_

6 #define UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_	6 #define UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_

7	7

8 #include "base/time/time.h"	8 #include "base/time/time.h"

9 #include "ui/gfx/skia_util.h"	9 #include "ui/gfx/skia_util.h"

10	10

11 namespace ui {	11 namespace ui {

12	12

13 constexpr int kOverlayScrollbarThumbWidthNormal = 6;	13 constexpr int kOverlayScrollbarThumbWidthNormal = 6;

14 constexpr int kOverlayScrollbarThumbWidthHovered = 10;	14 constexpr int kOverlayScrollbarThumbWidthHovered = 10;

15 constexpr int kOverlayScrollbarThumbWidthPressed = 10;	15 constexpr int kOverlayScrollbarThumbWidthPressed = 10;

16	16

	17 constexpr base::TimeDelta kOverlayScrollbarFadeInDelay =
	bokan 2017/02/27 23:13:56 Could you add a comment describing this value and Could you add a comment describing this value and mentioning that it's only for the case where the mouse hovers near the screen edge.
	18 base::TimeDelta::FromMilliseconds(1000);

17 constexpr base::TimeDelta kOverlayScrollbarFadeOutDelay =	19 constexpr base::TimeDelta kOverlayScrollbarFadeOutDelay =

18 base::TimeDelta::FromMilliseconds(1000);	20 base::TimeDelta::FromMilliseconds(1000);

19 constexpr base::TimeDelta kOverlayScrollbarFadeOutDuration =	21 constexpr base::TimeDelta kOverlayScrollbarFadeOutDuration =

20 base::TimeDelta::FromMilliseconds(200);	22 base::TimeDelta::FromMilliseconds(200);

21 // TODO(bokan): This is still undetermined. crbug.com/652520.	23 // TODO(bokan): This is still undetermined. crbug.com/652520.

22 constexpr base::TimeDelta kOverlayScrollbarThinningDuration =	24 constexpr base::TimeDelta kOverlayScrollbarThinningDuration =

23 base::TimeDelta::FromMilliseconds(200);	25 base::TimeDelta::FromMilliseconds(200);

24	26

25 } // namespace ui	27 } // namespace ui

26	28

27 #endif // UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_	29 #endif // UI_NATIVE_THEME_OVERLAY_SCROLLBAR_CONSTANTS_AURA_H_

OLD	NEW