Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: chrome/browser/sync/test/integration/sync_datatype_helper.h

Issue 2716413003: Initial clear server data impl (Closed)
Patch Set: Responding to CL comments. Some Logic changes, but mostly spelling/comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_datatype_helper.h
diff --git a/chrome/browser/sync/test/integration/sync_datatype_helper.h b/chrome/browser/sync/test/integration/sync_datatype_helper.h
index 770cfc3325b2452a6ffa4c267cf47904d265f973..4a85b1627bf64ad338fdc9bfb5215e53b79d8ef3 100644
--- a/chrome/browser/sync/test/integration/sync_datatype_helper.h
+++ b/chrome/browser/sync/test/integration/sync_datatype_helper.h
@@ -15,6 +15,12 @@ namespace sync_datatype_helper {
// used.
void AssociateWithTest(SyncTest* test);
+// Dissociates the test from us. When running tests consecutively, the tests
skym 2017/03/07 21:32:25 Interesting... So are you calling these tests diff
wylieb 2017/03/07 23:04:40 No, I think that this was introduced and nobody th
skym 2017/03/08 00:23:48 I don't understand. If I run a vanilla
wylieb 2017/03/08 00:58:51 I think I was mistaken, I removed it.
+// will fail by an assertion that there's already a test associated with this.
+// This function serves to reset the static variable, and allows for consecutive
+// runs without issue.
+void DissociateWithTest(SyncTest* test);
+
// Returns a pointer to the instance of SyncTest associated with the
// per-datatype helpers after making sure it is valid.
SyncTest* test();

Powered by Google App Engine
This is Rietveld 408576698