Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: ash/common/shelf/app_list_shelf_item_delegate.cc

Issue 2716403005: mash: Remove shelf app menu item objects. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/shelf/app_list_shelf_item_delegate.h ('k') | ash/common/shelf/shelf_application_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/app_list_shelf_item_delegate.cc
diff --git a/ash/common/shelf/app_list_shelf_item_delegate.cc b/ash/common/shelf/app_list_shelf_item_delegate.cc
index 2c04383cdd84c08d41457e9e45b85cefce619936..398b3cb2e530807e668a37f24d17cce98f6eb763 100644
--- a/ash/common/shelf/app_list_shelf_item_delegate.cc
+++ b/ash/common/shelf/app_list_shelf_item_delegate.cc
@@ -42,10 +42,16 @@ ShelfAction AppListShelfItemDelegate::ItemSelected(ui::EventType event_type,
ShelfAppMenuItemList AppListShelfItemDelegate::GetAppMenuItems(
int event_flags) {
- // AppList does not show an application menu.
+ // Return an empty item list to avoid showing an application menu.
return ShelfAppMenuItemList();
}
+void AppListShelfItemDelegate::ExecuteCommand(uint32_t command_id,
+ int event_flags) {
+ // This delegate does not support showing an application menu.
+ NOTIMPLEMENTED();
+}
+
void AppListShelfItemDelegate::Close() {}
} // namespace ash
« no previous file with comments | « ash/common/shelf/app_list_shelf_item_delegate.h ('k') | ash/common/shelf/shelf_application_menu_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698