mash: Remove shelf app menu item objects.

chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_BROWSER_SHORTCUT_LAUNCHER_ITEM_CONTROLLER_H_
 #define CHROME_BROWSER_UI_ASH_LAUNCHER_BROWSER_SHORTCUT_LAUNCHER_ITEM_CONTROLLER_H_
 
 #include "base/macros.h"
 #include "chrome/browser/ui/ash/launcher/launcher_item_controller.h"
 #include "chrome/browser/ui/browser_list.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
 
 namespace ash {
 class ShelfModel;
 }
 
 namespace content {
 class WebContents;
 }
 
-namespace gfx {
-class Image;
-}
-
-class Browser;
 class ChromeLauncherController;
 
 // Item controller for an browser shortcut.

[James Cook, 2017/03/01 19:50:48]

super nit: while you're here, can you update/clarify this comment? There's only
one browser shortcut, for example. Saying something about the expected menu
types would be nice too.

[msw, 2017/03/02 02:59:20]

Done.

-class BrowserShortcutLauncherItemController : public LauncherItemController {
+class BrowserShortcutLauncherItemController
+    : public LauncherItemController,
+      public content::NotificationObserver {
  public:
   BrowserShortcutLauncherItemController(ChromeLauncherController* controller,
                                         ash::ShelfModel* shelf_model);
 
   ~BrowserShortcutLauncherItemController() override;
 
   // Updates the activation state of the Broswer item.
   void UpdateBrowserItemState();
 
   // Sets the shelf id for the browser window if the browser is represented.
   void SetShelfIDForBrowserWindowContents(Browser* browser,
                                           content::WebContents* web_contents);
 
   // Check if there is any active browsers windows.
   bool IsListOfActiveBrowserEmpty();
 
   // LauncherItemController overrides:
   ash::ShelfAction ItemSelected(ui::EventType event_type,
                                 int event_flags,
                                 int64_t display_id,
                                 ash::ShelfLaunchSource source) override;
   ash::ShelfAppMenuItemList GetAppMenuItems(int event_flags) override;
+  void ExecuteCommand(uint32_t command_id, int32_t event_flags) override;
   void Close() override;
 
  private:
-  // Get the favicon for the browser list entry for |web_contents|.
-  // Note that for incognito windows the incognito icon will be returned.
-  gfx::Image GetBrowserListIcon(content::WebContents* web_contents) const;
-
-  // Get the title for the browser list entry for |web_contents|.
-  // If |web_contents| has not loaded, returns "Net Tab".
-  base::string16 GetBrowserListTitle(content::WebContents* web_contents) const;
-
-  // Check if the given |web_contents| is in incognito mode.
-  bool IsIncognito(content::WebContents* web_contents) const;
-
   // Activate a browser - or advance to the next one on the list.
   // Returns the action performed. Should be one of SHELF_ACTION_NONE,
   // SHELF_ACTION_WINDOW_ACTIVATED, or SHELF_ACTION_NEW_WINDOW_CREATED.
   ash::ShelfAction ActivateOrAdvanceToNextBrowser();
 
   // Returns true when the given |browser| is listed in the browser application
   // list.
   bool IsBrowserRepresentedInBrowserList(Browser* browser);
 
   // Get a list of active browsers.
   BrowserList::BrowserVector GetListOfActiveBrowsers();
 
+  // content::NotificationObserver:
+  void Observe(int type,
+               const content::NotificationSource& source,
+               const content::NotificationDetails& details) override;
+
   ash::ShelfModel* shelf_model_;
 
+  // The cached list of open browser windows shown in an application menu.
+  BrowserList::BrowserVector browser_menu_items_;
+
+  // Registers for notifications of closing browser windows.
+  content::NotificationRegistrar registrar_;
+
   DISALLOW_COPY_AND_ASSIGN(BrowserShortcutLauncherItemController);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_BROWSER_SHORTCUT_LAUNCHER_ITEM_CONTROLLER_H_