Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc

Issue 2716403005: mash: Remove shelf app menu item objects. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h" 5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 30 matching lines...) Expand all
41 #include "chrome/browser/ui/ash/app_launcher_id.h" 41 #include "chrome/browser/ui/ash/app_launcher_id.h"
42 #include "chrome/browser/ui/ash/app_sync_ui_state.h" 42 #include "chrome/browser/ui/ash/app_sync_ui_state.h"
43 #include "chrome/browser/ui/ash/chrome_shell_delegate.h" 43 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
44 #include "chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h " 44 #include "chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h "
45 #include "chrome/browser/ui/ash/launcher/app_window_launcher_controller.h" 45 #include "chrome/browser/ui/ash/launcher/app_window_launcher_controller.h"
46 #include "chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h" 46 #include "chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h"
47 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h" 47 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h"
48 #include "chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h" 48 #include "chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h"
49 #include "chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controll er.h" 49 #include "chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controll er.h"
50 #include "chrome/browser/ui/ash/launcher/browser_status_monitor.h" 50 #include "chrome/browser/ui/ash/launcher/browser_status_monitor.h"
51 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_browser.h "
52 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h"
53 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h" 51 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h"
54 #include "chrome/browser/ui/ash/launcher/launcher_arc_app_updater.h" 52 #include "chrome/browser/ui/ash/launcher/launcher_arc_app_updater.h"
55 #include "chrome/browser/ui/ash/launcher/launcher_controller_helper.h" 53 #include "chrome/browser/ui/ash/launcher/launcher_controller_helper.h"
56 #include "chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h" 54 #include "chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h"
57 #include "chrome/browser/ui/ash/launcher/launcher_item_controller.h" 55 #include "chrome/browser/ui/ash/launcher/launcher_item_controller.h"
58 #include "chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_contr oller.h" 56 #include "chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_contr oller.h"
59 #include "chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h" 57 #include "chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.h"
60 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h" 58 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
61 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h" 59 #include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h"
62 #include "chrome/browser/ui/browser.h" 60 #include "chrome/browser/ui/browser.h"
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 ash::Shell::GetInstance()->CreateKeyboard(); 608 ash::Shell::GetInstance()->CreateKeyboard();
611 } 609 }
612 610
613 void ChromeLauncherControllerImpl::AdditionalUserAddedToSession( 611 void ChromeLauncherControllerImpl::AdditionalUserAddedToSession(
614 Profile* profile) { 612 Profile* profile) {
615 // Switch the running applications to the new user. 613 // Switch the running applications to the new user.
616 for (auto& controller : app_window_controllers_) 614 for (auto& controller : app_window_controllers_)
617 controller->AdditionalUserAddedToSession(profile); 615 controller->AdditionalUserAddedToSession(profile);
618 } 616 }
619 617
620 ash::ShelfAppMenuItemList ChromeLauncherControllerImpl::GetAppMenuItems( 618 ash::ShelfAppMenuItemList
621 const ash::ShelfItem& item, 619 ChromeLauncherControllerImpl::GetAppMenuItemsForTesting(
622 int event_flags) { 620 const ash::ShelfItem& item) {
623 LauncherItemController* controller = GetLauncherItemController(item.id); 621 LauncherItemController* controller = GetLauncherItemController(item.id);
624 return controller ? controller->GetAppMenuItems(event_flags) 622 return controller ? controller->GetAppMenuItems(ui::EF_NONE)
625 : ash::ShelfAppMenuItemList(); 623 : ash::ShelfAppMenuItemList();
626 } 624 }
627 625
628 std::vector<content::WebContents*> 626 std::vector<content::WebContents*>
629 ChromeLauncherControllerImpl::GetV1ApplicationsFromAppId( 627 ChromeLauncherControllerImpl::GetV1ApplicationsFromAppId(
630 const std::string& app_id) { 628 const std::string& app_id) {
631 const ash::ShelfItem* item = GetItem(GetShelfIDForAppID(app_id)); 629 const ash::ShelfItem* item = GetItem(GetShelfIDForAppID(app_id));
632 // If there is no such item pinned to the launcher, no menu gets created. 630 // If there is no such item pinned to the launcher, no menu gets created.
633 if (!item || item->type != ash::TYPE_APP_SHORTCUT) 631 if (!item || item->type != ash::TYPE_APP_SHORTCUT)
634 return std::vector<content::WebContents*>(); 632 return std::vector<content::WebContents*>();
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
1492 LauncherItemController* controller = GetLauncherItemController(item.id); 1490 LauncherItemController* controller = GetLauncherItemController(item.id);
1493 if (!controller || controller->image_set_by_controller()) 1491 if (!controller || controller->image_set_by_controller())
1494 continue; 1492 continue;
1495 item.image = image; 1493 item.image = image;
1496 if (arc_deferred_launcher_) 1494 if (arc_deferred_launcher_)
1497 arc_deferred_launcher_->MaybeApplySpinningEffect(id, &item.image); 1495 arc_deferred_launcher_->MaybeApplySpinningEffect(id, &item.image);
1498 model_->Set(index, item); 1496 model_->Set(index, item);
1499 // It's possible we're waiting on more than one item, so don't break. 1497 // It's possible we're waiting on more than one item, so don't break.
1500 } 1498 }
1501 } 1499 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698