ash/public/cpp/shelf_application_menu_item.cc - Issue 2716403005: mash: Remove shelf app menu item objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/public/cpp/shelf_application_menu_item.cc

Issue 2716403005: mash: Remove shelf app menu item objects. (Closed)

Patch Set: Address comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/public/cpp/shelf_application_menu_item.h"	5 #include "ash/public/cpp/shelf_application_menu_item.h"

6	6

7 namespace ash {	7 namespace ash {

8	8

9 ShelfApplicationMenuItem::ShelfApplicationMenuItem(const base::string16 title,	9 ShelfApplicationMenuItem::ShelfApplicationMenuItem(uint32_t command_id,

	10 const base::string16& title,

10 const gfx::Image* icon)	11 const gfx::Image* icon)

11 : title_(title), icon_(icon ? gfx::Image(*icon) : gfx::Image()) {}	12 : command_id_(command_id),

	13 title_(title),

	14 icon_(icon ? gfx::Image(*icon) : gfx::Image()) {}

12	15

13 ShelfApplicationMenuItem::~ShelfApplicationMenuItem() {}	16 ShelfApplicationMenuItem::~ShelfApplicationMenuItem() {}

14	17

15 void ShelfApplicationMenuItem::Execute(int event_flags) {}

16

17 } // namespace ash	18 } // namespace ash

OLD	NEW

« no previous file with comments | « ash/public/cpp/shelf_application_menu_item.h ('k') | ash/shelf/shelf_view_unittest.cc » ('j') | no next file with comments »