Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: ash/common/shelf/shelf_application_menu_model.h

Issue 2716403005: mash: Remove shelf app menu item objects. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 5 #ifndef ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
6 #define ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 6 #define ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
11 #include "ash/ash_export.h" 11 #include "ash/ash_export.h"
12 #include "ash/public/cpp/shelf_application_menu_item.h" 12 #include "ash/public/cpp/shelf_application_menu_item.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "ui/base/models/simple_menu_model.h" 14 #include "ui/base/models/simple_menu_model.h"
15 15
16 namespace ash {
17
16 class ShelfApplicationMenuModelTestAPI; 18 class ShelfApplicationMenuModelTestAPI;
17 19 class ShelfItemDelegate;
18 namespace ash {
19 20
20 // A menu model listing open applications associated with a shelf item. Layout: 21 // A menu model listing open applications associated with a shelf item. Layout:
21 // +---------------------------+ 22 // +---------------------------+
22 // | | 23 // | |
23 // | App Title | 24 // | App Title |
24 // | | 25 // | |
25 // | [Icon] Item Title | 26 // | [Icon] Item Title |
26 // | [Icon] Item Title | 27 // | [Icon] Item Title |
27 // | | 28 // | |
28 // +---------------------------+ 29 // +---------------------------+
29 class ASH_EXPORT ShelfApplicationMenuModel 30 class ASH_EXPORT ShelfApplicationMenuModel
30 : public ui::SimpleMenuModel, 31 : public ui::SimpleMenuModel,
31 public ui::SimpleMenuModel::Delegate { 32 public ui::SimpleMenuModel::Delegate {
32 public: 33 public:
33 // Makes a menu with a |title|, separators, and the specified |items|. 34 // Makes a menu with a |title|, separators, and |items| for |delegate|.
35 // |delegate| may be null in unit tests that do not execute commands.
34 ShelfApplicationMenuModel(const base::string16& title, 36 ShelfApplicationMenuModel(const base::string16& title,
35 ShelfAppMenuItemList items); 37 ShelfAppMenuItemList items,
38 ShelfItemDelegate* delegate);
36 ~ShelfApplicationMenuModel() override; 39 ~ShelfApplicationMenuModel() override;
37 40
38 // ui::SimpleMenuModel::Delegate: 41 // ui::SimpleMenuModel::Delegate:
39 bool IsCommandIdChecked(int command_id) const override; 42 bool IsCommandIdChecked(int command_id) const override;
40 bool IsCommandIdEnabled(int command_id) const override; 43 bool IsCommandIdEnabled(int command_id) const override;
41 void ExecuteCommand(int command_id, int event_flags) override; 44 void ExecuteCommand(int command_id, int event_flags) override;
42 45
43 private: 46 private:
44 friend class ShelfApplicationMenuModelTestAPI; 47 friend class ShelfApplicationMenuModelTestAPI;
45 48
46 // Records UMA metrics when a menu item is selected. 49 // Records UMA metrics when a menu item is selected.
47 void RecordMenuItemSelectedMetrics(int command_id, 50 void RecordMenuItemSelectedMetrics(int command_id,
48 int num_menu_items_enabled); 51 int num_menu_items_enabled);
49 52
50 // The list of menu items as returned from the shelf item's controller. 53 // The list of menu items as returned from the shelf item's controller.
51 ShelfAppMenuItemList items_; 54 ShelfAppMenuItemList items_;
52 55
56 // The shelf item delegate that created the menu and executes its commands.
57 ShelfItemDelegate* delegate_;
58
53 DISALLOW_COPY_AND_ASSIGN(ShelfApplicationMenuModel); 59 DISALLOW_COPY_AND_ASSIGN(ShelfApplicationMenuModel);
54 }; 60 };
55 61
56 } // namespace ash 62 } // namespace ash
57 63
58 #endif // ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_ 64 #endif // ASH_COMMON_SHELF_SHELF_APPLICATION_MENU_MODEL_H_
OLDNEW
« no previous file with comments | « ash/common/shelf/app_list_shelf_item_delegate.cc ('k') | ash/common/shelf/shelf_application_menu_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698