Issue 27164003: Reenable 17167: "Ensure lower <= upper bound"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27164003: Reenable 17167: "Ensure lower <= upper bound" (Closed)

Created:
7 years, 2 months ago by rossberg

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reenable 17167: "Ensure lower <= upper bound" Fixed handlification bug (see 2nd patch). Will handlify Type::Union and Type::Intersect in separate CL. R=mstarzinger@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=17189

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -22 lines)			Patch
M	src/types.h	View		4 chunks	+23 lines, -8 lines	0 comments	Download
M	src/types.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/typing.cc	View	1	4 chunks	+20 lines, -12 lines	0 comments	Download
M	test/cctest/test-types.cc	View		9 chunks	+25 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

LGTM (reviewed patch set #2, rubber-stamped the rest).

7 years, 2 months ago (2013-10-14 11:58:27 UTC) #2

rossberg

7 years, 2 months ago (2013-10-14 12:15:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17189 (presubmit successful).