Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2647)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.cc

Issue 2716373002: predictors: Call StopPrefetching with an url before redirect. (Closed)
Patch Set: Fix nit #2. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.cc b/chrome/browser/predictors/resource_prefetch_predictor.cc
index a2916bad115c7bec68f67b61b61c50f1a7bdc263..2069dbdf4df6fb9ddaa7e7487f3924f5ab9b7333 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor.cc
@@ -606,6 +606,9 @@ void ResourcePrefetchPredictor::StartPrefetching(const GURL& url,
BrowserThread::IO, FROM_HERE,
base::Bind(&ResourcePrefetcherManager::MaybeAddPrefetch,
prefetch_manager_, url, prediction.subresource_urls));
+
+ if (observer_)
+ observer_->OnPrefetchingStarted(url);
}
void ResourcePrefetchPredictor::StopPrefetching(const GURL& url) {
@@ -625,6 +628,9 @@ void ResourcePrefetchPredictor::StopPrefetching(const GURL& url) {
BrowserThread::IO, FROM_HERE,
base::Bind(&ResourcePrefetcherManager::MaybeRemovePrefetch,
prefetch_manager_, url));
+
+ if (observer_)
+ observer_->OnPrefetchingStopped(url);
}
void ResourcePrefetchPredictor::OnPrefetchingFinished(
@@ -675,15 +681,22 @@ void ResourcePrefetchPredictor::OnMainFrameRequest(
void ResourcePrefetchPredictor::OnMainFrameResponse(
const URLRequestSummary& response) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (initialization_state_ != INITIALIZED)
- return;
+ DCHECK_EQ(INITIALIZED, initialization_state_);
- StopPrefetching(response.navigation_id.main_frame_url);
+ NavigationMap::iterator nav_it =
+ inflight_navigations_.find(response.navigation_id);
+ if (nav_it != inflight_navigations_.end()) {
+ // To match an URL in StartPrefetching().
+ StopPrefetching(nav_it->second->initial_url);
+ } else {
+ StopPrefetching(response.navigation_id.main_frame_url);
+ }
}
void ResourcePrefetchPredictor::OnMainFrameRedirect(
const URLRequestSummary& response) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ DCHECK_EQ(INITIALIZED, initialization_state_);
const GURL& main_frame_url = response.navigation_id.main_frame_url;
std::unique_ptr<PageRequestSummary> summary;
@@ -715,6 +728,7 @@ void ResourcePrefetchPredictor::OnMainFrameRedirect(
void ResourcePrefetchPredictor::OnSubresourceResponse(
const URLRequestSummary& response) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ DCHECK_EQ(INITIALIZED, initialization_state_);
NavigationMap::const_iterator nav_it =
inflight_navigations_.find(response.navigation_id);
@@ -728,6 +742,7 @@ void ResourcePrefetchPredictor::OnSubresourceResponse(
void ResourcePrefetchPredictor::OnNavigationComplete(
const NavigationID& nav_id_without_timing_info) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ DCHECK_EQ(INITIALIZED, initialization_state_);
NavigationMap::iterator nav_it =
inflight_navigations_.find(nav_id_without_timing_info);
@@ -903,10 +918,16 @@ void ResourcePrefetchPredictor::CleanupAbandonedNavigations(
for (auto it = inflight_prefetches_.begin();
it != inflight_prefetches_.end();) {
- if (time_now - it->second > max_navigation_age)
+ base::TimeDelta prefetch_age = time_now - it->second;
+ if (prefetch_age > max_navigation_age) {
+ // It goes to the last bucket meaning that the duration was unlimited.
+ UMA_HISTOGRAM_TIMES(
+ internal::kResourcePrefetchPredictorPrefetchingDurationHistogram,
+ prefetch_age);
it = inflight_prefetches_.erase(it);
- else
+ } else {
++it;
+ }
}
// Remove old prefetches that haven't been claimed.

Powered by Google App Engine
This is Rietveld 408576698