[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/views/extensions/extension_install_dialog_view.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_
 
 #include "base/macros.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "ui/gfx/animation/animation_delegate.h"
@@ skipping 32 matching lines @@
       Profile* profile,
       content::PageNavigator* navigator,
       const ExtensionInstallPrompt::DoneCallback& done_callback,
       std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt);
   ~ExtensionInstallDialogView() override;
 
   // Returns the interior ScrollView of the dialog. This allows us to inspect
   // the contents of the DialogView.
   const views::ScrollView* scroll_view() const { return scroll_view_; }
 
+  static void SetInstallDelayForTesting(int timeout_in_ms);
+
  private:
   // views::View:
   void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
+  void VisibilityChanged(views::View* starting_from, bool is_visible) override;
 
   // views::DialogDelegateView:
   int GetDialogButtons() const override;
   base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
   int GetDefaultDialogButton() const override;
   bool Cancel() override;
   bool Accept() override;
   ui::ModalType GetModalType() const override;
   void Layout() override;
   gfx::Size GetPreferredSize() const override;
   views::View* CreateExtraView() override;
+  bool IsDialogButtonEnabled(ui::DialogButton button) const override;
 
   // views::LinkListener:
   void LinkClicked(views::Link* source, int event_flags) override;
 
   // Initializes the dialog view, adding in permissions if they exist.
   void InitView();
 
+  // Enables installs and updates the dialog buttons.

[Devlin, 2017/03/31 22:21:41]

nitty nit: Maybe "Enables the ['install'|'accept'] button."?  "Enables installs"
sounds kinda weird to me for some reason... but maybe just me.

[Ackerman, 2017/04/01 01:48:37]

Yeah, it's a little awkward. I will change it to enable install button. I also
renamed a couple of other things to make it more clear as well.

+  void EnableInstall();

[Devlin, 2017/03/31 22:21:41]

similarly, maybe Enable[Install|Accept]Button.

[Ackerman, 2017/04/01 01:48:37]

Done.

+
   // Adds permissions of |perm_type| to the dialog view if they exist.
   bool AddPermissions(views::GridLayout* layout,
                       ui::ResourceBundle& rb,
                       int column_set_id,
                       int left_column_width,
                       ExtensionInstallPrompt::PermissionsType perm_type);
 
   // Creates a layout consisting of dialog header, extension name and icon.
   views::GridLayout* CreateLayout(int left_column_width, int column_set_id);
 
@@ skipping 21 matching lines @@
   // The preferred size of the dialog.
   gfx::Size dialog_size_;
 
   // ExperienceSampling: Track this UI event.
   std::unique_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
 
   // Set to true once the user's selection has been received and the callback
   // has been run.
   bool handled_result_;
 
+  // Used to delay the activation of the install button.
+  base::OneShotTimer timer_;
+
+  // Default to not allow installs.
+  bool install_enabled_ = false;

[Devlin, 2017/03/31 22:21:41]

We should be consistent in our initialization of POD in classes.  So either move
this initialization to the ctor definition, or add initializers for the rest of
the POD in this class. (Either is fine; the former is less work.)

[Ackerman, 2017/04/01 01:48:37]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallDialogView);
 };
 
 // A simple view that prepends a view with a bullet with the help of a grid
 // layout.
 class BulletedView : public views::View {
  public:
   explicit BulletedView(views::View* view);
  private:
   DISALLOW_COPY_AND_ASSIGN(BulletedView);
@@ skipping 64 matching lines @@
   // on whether the details section is expanded).
   views::ImageButton* arrow_toggle_;
 
   // Whether the details section is expanded.
   bool expanded_;
 
   DISALLOW_COPY_AND_ASSIGN(ExpandableContainerView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALL_DIALOG_VIEW_H_