[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 33 matching lines @@
 #include "ui/views/border.h"
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/scroll_view.h"
 #include "ui/views/controls/separator.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_client_view.h"
 
 using content::OpenURLParams;
 using content::Referrer;
 using extensions::ExperienceSamplingEvent;
 
 namespace {
 
 // Width of the bullet column in BulletedView.
 constexpr int kBulletWidth = 20;
 
@@ skipping 19 matching lines @@
 // points. If the parent is using bullets for its items, then a padding of one
 // unit will make the child item (which has no bullet) look like a sibling of
 // its parent. Therefore increase the indentation by one more unit to show that
 // it is in fact a child item (with no missing bullet) and not a sibling.
 int GetLeftPaddingForBulletedItems(bool parent_bulleted) {
   return LayoutDelegate::Get()->GetMetric(
              LayoutDelegate::Metric::RELATED_CONTROL_HORIZONTAL_SPACING) *
          (parent_bulleted ? 2 : 1);
 }
 
+// Time delay before the install button is enabled after initial display.
+int g_install_delay_in_ms = 500;
+
 void AddResourceIcon(const gfx::ImageSkia* skia_image, void* data) {
   views::View* parent = static_cast<views::View*>(data);
   views::ImageView* image_view = new views::ImageView();
   image_view->SetImage(*skia_image);
   parent->AddChildView(image_view);
 }
 
 // Creates a string for displaying |message| to the user. If it has to look
 // like a entry in a bullet point list, one is added.
 base::string16 PrepareForDisplay(const base::string16& message,
@@ skipping 485 matching lines @@
 views::View* ExtensionInstallDialogView::CreateExtraView() {
   if (!prompt_->has_webstore_data())
     return nullptr;
 
   views::Link* store_link = new views::Link(
       l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_STORE_LINK));
   store_link->set_listener(this);
   return store_link;
 }
 
+bool ExtensionInstallDialogView::IsDialogButtonEnabled(
+    ui::DialogButton button) const {
+  if (button == ui::DIALOG_BUTTON_OK)
+    return install_enabled_;
+  return true;
+}
+
+void ExtensionInstallDialogView::SetInstallDelayForTesting(int delay_in_ms) {
+  g_install_delay_in_ms = delay_in_ms;
+}
+
+void ExtensionInstallDialogView::VisibilityChanged(views::View* starting_from,
+                                                   bool is_visible) {
+  if (is_visible) {

[Devlin, 2017/03/31 22:21:41]

We should make this:
if (is_visible && !install_enabled_)

so that subsequent changes to visibility don't trigger the timer unnecessarily.

[Ackerman, 2017/04/01 01:48:37]

Done.

+    timer_.Start(FROM_HERE,
+                 base::TimeDelta::FromMilliseconds(g_install_delay_in_ms),
+                 base::Bind(&ExtensionInstallDialogView::EnableInstall,
+                            base::Unretained(this)));

[Devlin, 2017/03/31 22:21:41]

Each time I see this unretained, it makes me nervous, and then I realize why
it's safe.  Can we add a quick comment above Start() that says:
// This base::Unretained is safe because the task is owned by the timer, which
is in turn owned by this object.

[Ackerman, 2017/04/01 01:48:37]

Done.

+  }
+}
+
+void ExtensionInstallDialogView::EnableInstall() {
+  install_enabled_ = true;
+  GetDialogClientView()->UpdateDialogButtons();
+}
+
 void ExtensionInstallDialogView::UpdateInstallResultHistogram(bool accepted)
     const {
   if (prompt_->type() == ExtensionInstallPrompt::INSTALL_PROMPT)
     UMA_HISTOGRAM_BOOLEAN("Extensions.InstallPrompt.Accepted", accepted);
 }
 
 // ExpandableContainerView::DetailsView ----------------------------------------
 
 ExpandableContainerView::DetailsView::DetailsView(int horizontal_space,
                                                   bool parent_bulleted)
@@ skipping 148 matching lines @@
   gfx::ImageSkia icon = gfx::CreateVectorIcon(
       expanded ? kCaretUpIcon : kCaretDownIcon, gfx::kChromeIconGrey);
   arrow_toggle_->SetImage(views::Button::STATE_NORMAL, &icon);
 }
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetViewsShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }