[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <string>
 #include <utility>
@@ skipping 33 matching lines @@
 #include "ui/views/controls/button/image_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/scroll_view.h"
 #include "ui/views/controls/separator.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_client_view.h"
 
 using content::OpenURLParams;
 using content::Referrer;
 using extensions::ExperienceSamplingEvent;
 
 namespace {
 
 // Width of the bullet column in BulletedView.
 const int kBulletWidth = 20;
 
 // Size of extension icon in top left of dialog.
 const int kIconSize = 64;
 
 // The maximum height of the scroll view before it will show a scrollbar.
 const int kScrollViewMaxHeight = 250;
 
 // Width of the left column of the dialog when the extension requests
 // permissions.
 const int kPermissionsLeftColumnWidth = 250;
 
 // Width of the left column of the dialog when the extension requests no
 // permissions.
 const int kNoPermissionsLeftColumnWidth = 200;
 
 // Width of the left column for external install prompts. The text is long in
 // this case, so make it wider than normal.
 const int kExternalInstallLeftColumnWidth = 350;
 
+// Time delay to enable the install button after initial display.
+int g_install_delay_in_ms = 500;
+
 void AddResourceIcon(const gfx::ImageSkia* skia_image, void* data) {
   views::View* parent = static_cast<views::View*>(data);
   views::ImageView* image_view = new views::ImageView();
   image_view->SetImage(*skia_image);
   parent->AddChildView(image_view);
 }
 
 // Creates a string for displaying |message| to the user. If it has to look
 // like a entry in a bullet point list, one is added.
 base::string16 PrepareForDisplay(const base::string16& message,
@@ skipping 73 matching lines @@
     const ExtensionInstallPrompt::DoneCallback& done_callback,
     std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt)
     : profile_(profile),
       navigator_(navigator),
       done_callback_(done_callback),
       prompt_(std::move(prompt)),
       container_(NULL),
       scroll_view_(NULL),
       handled_result_(false) {
   InitView();
+  StartTimerToEnableInstall();

[Devlin, 2017/03/23 01:25:30]

Here, too, just because the dialog is constructed doesn't mean it's visible.  I
think the canonical way to observe view visibility changes in Views is with
views::WidgetObserver::OnWidgetVisibilityChanged.  So we probably want to
observe this dialog's widget (accessible with GetWidget()), and wait for that.

[Ackerman, 2017/03/31 22:03:22]

Done.

 }
 
 ExtensionInstallDialogView::~ExtensionInstallDialogView() {
   if (!handled_result_ && !done_callback_.is_null()) {
     base::ResetAndReturn(&done_callback_)
         .Run(ExtensionInstallPrompt::Result::USER_CANCELED);
   }
 }
 
 void ExtensionInstallDialogView::InitView() {
@@ skipping 376 matching lines @@
 views::View* ExtensionInstallDialogView::CreateExtraView() {
   if (!prompt_->has_webstore_data())
     return nullptr;
 
   views::Link* store_link = new views::Link(
       l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_STORE_LINK));
   store_link->set_listener(this);
   return store_link;
 }
 
+bool ExtensionInstallDialogView::IsDialogButtonEnabled(
+    ui::DialogButton button) const {
+  if (button == ui::DIALOG_BUTTON_OK)
+    return install_enabled_;
+  return true;
+}
+
+void ExtensionInstallDialogView::StartTimerToEnableInstall() {
+  timer_.Start(FROM_HERE,

[Devlin, 2017/03/23 01:25:30]

Here too, let's just inline this at the call site.

[Ackerman, 2017/03/31 22:03:21]

Done.

+               base::TimeDelta::FromMilliseconds(g_install_delay_in_ms),
+               base::Bind(&ExtensionInstallDialogView::EnableInstall,
+                          base::Unretained(this)));
+}
+
+void ExtensionInstallDialogView::SetInstallDelayForTesting(int delay_in_ms) {
+  g_install_delay_in_ms = delay_in_ms;
+}
+
+void ExtensionInstallDialogView::EnableInstall() {
+  install_enabled_ = true;
+  GetDialogClientView()->UpdateDialogButtons();
+}
+
 void ExtensionInstallDialogView::UpdateInstallResultHistogram(bool accepted)
     const {
   if (prompt_->type() == ExtensionInstallPrompt::INSTALL_PROMPT)
     UMA_HISTOGRAM_BOOLEAN("Extensions.InstallPrompt.Accepted", accepted);
 }
 
 // ExpandableContainerView::DetailsView ----------------------------------------
 
 ExpandableContainerView::DetailsView::DetailsView(int horizontal_space,
                                                   bool parent_bulleted)
@@ skipping 159 matching lines @@
   gfx::ImageSkia icon = gfx::CreateVectorIcon(
       expanded ? kCaretUpIcon : kCaretDownIcon, gfx::kChromeIconGrey);
   arrow_toggle_->SetImage(views::Button::STATE_NORMAL, &icon);
 }
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetViewsShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }