[Extensions UI] Initially disabled OK button for extension install prompts.

chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 79 matching lines @@
 // it.
 const CGFloat kWarningsSeparatorPadding = 14;
 
 // The left padding for the link cell.
 const CGFloat kLinkCellPaddingLeft = 3;
 
 // Maximum height we will adjust controls to when trying to accomodate their
 // contents.
 const CGFloat kMaxControlHeight = 250;
 
+// Time delay before the install button is enabled after initial display.
+NSTimeInterval g_install_delay_in_s = 0.5;

[Avi (use Gerrit), 2017/03/23 02:32:33]

camelcase. No "in s".

[Ackerman, 2017/03/31 22:03:21]

Noted.

+
 NSString* const kTitleKey = @"title";
 NSString* const kChildrenKey = @"children";
 NSString* const kCellAttributesKey = @"cellAttributes";
 NSString* const kPermissionsDetailIndex = @"permissionsDetailIndex";
 NSString* const kPermissionsDetailType = @"permissionsDetailType";
 
 // Computes the |control|'s desired height to fit its contents, constrained to
 // be kMaxControlHeight at most.
 CGFloat ComputeDesiredControlHeight(NSControl* control) {
   NSRect rect = [control frame];
@@ skipping 267 matching lines @@
     [[outlineView_ enclosingScrollView] setHidden:YES];
     totalOffset -= NSHeight(hiddenRect) + kWarningsSeparatorPadding;
   }
 
   // If necessary, adjust the window size.
   if (totalOffset) {
     NSRect currentRect = [[self view] bounds];
     currentRect.size.height += totalOffset;
     [self updateViewFrame:currentRect];
   }
+
+  // Default state of install button is disabled and then enabled after a short
+  // time delay.
+  [okButton_ setEnabled:NO];
+  [self startTimerToEnableInstall];

[Devlin, 2017/03/23 01:25:29]

I'm a little worried that we start this at construction, rather than at
appearance.  During a particularly laggy flow, that might mean that the button
is enabled before the dialog is shown.  We should probably start the timer in
response to the view being displayed.

[Ackerman, 2017/03/31 22:03:21]

Noted. This will require a little work, so I'm going to separate out the views
and cocoa changes from each other.

 }
 
 - (BOOL)hasWebstoreData {
   return prompt_->has_webstore_data();
 }
 
 - (void)appendRatingStar:(const gfx::ImageSkia*)skiaImage {
   NSImage* image = gfx::NSImageFromImageSkiaWithColorSpace(
       *skiaImage, base::mac::GetSystemColorSpace());
   NSRect frame = NSMakeRect(0, 0, skiaImage->width(), skiaImage->height());
@@ skipping 372 matching lines @@
 
   return SysUTF16ToNSString(prompt.GetPermissionsHeading(type));
 }
 
 - (void)updateViewFrame:(NSRect)frame {
   NSWindow* window = [[self view] window];
   [window setFrame:[window frameRectForContentRect:frame] display:YES];
   [[self view] setFrame:frame];
 }
 
+- (void)startTimerToEnableInstall {
+  [NSTimer scheduledTimerWithTimeInterval:g_install_delay_in_s

[Devlin, 2017/03/23 01:25:29]

nit: maybe just inline this method

[Ackerman, 2017/03/31 22:03:21]

Noted.

+                                   target:self
+                                 selector:@selector(enableInstall:)
+                                 userInfo:nil
+                                  repeats:NO];
+}
+
+- (void)enableInstall:(NSTimer*)timer {
+  [okButton_ setEnabled:YES];
+}
+
++ (void)setInstallDelayForTesting:(NSTimeInterval)time_delay_in_s {
+  g_install_delay_in_s = time_delay_in_s;
+}
+
 @end
 
 
 @implementation DetailToggleHyperlinkButtonCell
 
 @synthesize permissionsDetailIndex = permissionsDetailIndex_;
 @synthesize permissionsDetailType = permissionsDetailType_;
 @synthesize linkClickedAction = linkClickedAction_;
 
 + (BOOL)prefersTrackingUntilMouseUp {
@@ skipping 49 matching lines @@
 }
 
 - (void)accessibilityPerformAction:(NSString*)action {
   if ([action isEqualToString:NSAccessibilityPressAction])
     [self handleLinkClicked];
   else
     [super accessibilityPerformAction:action];
 }
 
 @end