chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2716333002: Implement important sites dialog for desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)

Patch Set: change element.$.someId to element.$$(#someId) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 142657eaac9fd31b9ec0b38cc1f5e4753fe30e9b..ea81faacf23901c7e2491102f098f6c74b41f4dc 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -526,8 +526,10 @@ void AddClearBrowsingDataStrings(content::WebUIDataSource* html_source) {

{"clearBrowsingDataLearnMoreUrl", IDS_SETTINGS_CLEAR_DATA_LEARN_MORE_URL},

{"historyDeletionDialogTitle",

IDS_CLEAR_BROWSING_DATA_HISTORY_NOTICE_TITLE},

- {"historyDeletionDialogOK",

- IDS_CLEAR_BROWSING_DATA_HISTORY_NOTICE_OK},

+ {"historyDeletionDialogOK", IDS_CLEAR_BROWSING_DATA_HISTORY_NOTICE_OK},

+ {"importantSitesSubtitle", IDS_SETTINGS_IMPORTANT_SITES_SUBTITLE},

+ {"importantSitesConfirm", IDS_SETTINGS_IMPORTANT_SITES_CONFIRM},

+ {"notificationWarning", IDS_SETTINGS_NOTIFICATION_WARNING},

};

html_source->AddString(

@@ -1516,6 +1518,10 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

+ html_source->AddBoolean(

+ "importantSitesInCbd",

+ base::FeatureList::IsEnabled(features::kImportantSitesInCbd));

html_source->AddLocalizedString(

"safeBrowsingEnableExtendedReporting",

safe_browsing::ChooseOptInTextResource(