Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/browser/engagement/important_sites_util.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: change element.$.someId to element.$$(#someId) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/engagement/important_sites_util.h ('k') | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/important_sites_util.cc
diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/engagement/important_sites_util.cc
index d0280d5f01b4fe788815011bff82fc8323bf4db7..fa56c26bc196293a42e04d827fd83f4ce211dda5 100644
--- a/chrome/browser/engagement/important_sites_util.cc
+++ b/chrome/browser/engagement/important_sites_util.cc
@@ -36,6 +36,7 @@
namespace {
using bookmarks::BookmarkModel;
using ImportantDomainInfo = ImportantSitesUtil::ImportantDomainInfo;
+using ImportantReason = ImportantSitesUtil::ImportantReason;
// Note: These values are stored on both the per-site content settings
// dictionary and the dialog preference dictionary.
@@ -51,16 +52,6 @@ static const int kTimesIgnoredForBlacklist = 3;
// bookmarks on site engagement > 0, sort, and trim to kMaxBookmarks.
static const int kMaxBookmarks = 5;
-// Do not change the values here, as they are used for UMA histograms.
-enum ImportantReason {
- ENGAGEMENT = 0,
- DURABLE = 1,
- BOOKMARKS = 2,
- HOME_SCREEN = 3,
- NOTIFICATIONS = 4,
- REASON_BOUNDARY
-};
-
// We need this to be a macro, as the histogram macros cache their pointers
// after the first call, so when we change the uma name we check fail if we're
// just a method.
« no previous file with comments | « chrome/browser/engagement/important_sites_util.h ('k') | chrome/browser/flag_descriptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698