chrome/browser/engagement/important_sites_util.cc - Issue 2716333002: Implement important sites dialog for desktop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/important_sites_util.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)

Patch Set: move filter creation back, add notification status Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/important_sites_util.cc

diff --git a/chrome/browser/engagement/important_sites_util.cc b/chrome/browser/engagement/important_sites_util.cc

index c266bd0d0265ce97ac68f5490e82d6f8a191f4d3..da6d7e6cf6425493a251d5af6fe1eeeb9e8b71d6 100644

--- a/chrome/browser/engagement/important_sites_util.cc

+++ b/chrome/browser/engagement/important_sites_util.cc

@@ -350,6 +350,10 @@ void PopulateInfoMapWithHomeScreen(

} // namespace

+bool ImportantSitesUtil::HasNotifications(const ImportantDomainInfo& info) {

+ return (info.reason_bitfield & (1 << ImportantReason::NOTIFICATIONS)) != 0;

bool ImportantSitesUtil::IsDialogDisabled(Profile* profile) {

PrefService* service = profile->GetPrefs();

DictionaryPrefUpdate update(service, prefs::kImportantSitesDialogHistory);