Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: change element.$.someId to element.$$(#someId) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/metrics_handler.h" 5 #include "chrome/browser/ui/webui/metrics_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 14 matching lines...) Expand all
25 25
26 void MetricsHandler::RegisterMessages() { 26 void MetricsHandler::RegisterMessages() {
27 web_ui()->RegisterMessageCallback( 27 web_ui()->RegisterMessageCallback(
28 "metricsHandler:recordAction", 28 "metricsHandler:recordAction",
29 base::Bind(&MetricsHandler::HandleRecordAction, base::Unretained(this))); 29 base::Bind(&MetricsHandler::HandleRecordAction, base::Unretained(this)));
30 web_ui()->RegisterMessageCallback( 30 web_ui()->RegisterMessageCallback(
31 "metricsHandler:recordInHistogram", 31 "metricsHandler:recordInHistogram",
32 base::Bind(&MetricsHandler::HandleRecordInHistogram, 32 base::Bind(&MetricsHandler::HandleRecordInHistogram,
33 base::Unretained(this))); 33 base::Unretained(this)));
34 web_ui()->RegisterMessageCallback( 34 web_ui()->RegisterMessageCallback(
35 "metricsHandler:recordBooleanHistogram",
36 base::Bind(&MetricsHandler::HandleRecordBooleanHistogram,
37 base::Unretained(this)));
38 web_ui()->RegisterMessageCallback(
35 "metricsHandler:recordTime", 39 "metricsHandler:recordTime",
36 base::Bind(&MetricsHandler::HandleRecordTime, base::Unretained(this))); 40 base::Bind(&MetricsHandler::HandleRecordTime, base::Unretained(this)));
37 web_ui()->RegisterMessageCallback( 41 web_ui()->RegisterMessageCallback(
38 "metricsHandler:logEventTime", 42 "metricsHandler:logEventTime",
39 base::Bind(&MetricsHandler::HandleLogEventTime, base::Unretained(this))); 43 base::Bind(&MetricsHandler::HandleLogEventTime, base::Unretained(this)));
40 } 44 }
41 45
42 void MetricsHandler::HandleRecordAction(const base::ListValue* args) { 46 void MetricsHandler::HandleRecordAction(const base::ListValue* args) {
43 std::string string_action = base::UTF16ToUTF8(ExtractStringValue(args)); 47 std::string string_action = base::UTF16ToUTF8(ExtractStringValue(args));
44 base::RecordComputedAction(string_action); 48 base::RecordComputedAction(string_action);
(...skipping 26 matching lines...) Expand all
71 75
72 // As |histogram_name| may change between calls, the UMA_HISTOGRAM_ENUMERATION 76 // As |histogram_name| may change between calls, the UMA_HISTOGRAM_ENUMERATION
73 // macro cannot be used here. 77 // macro cannot be used here.
74 base::HistogramBase* counter = 78 base::HistogramBase* counter =
75 base::LinearHistogram::FactoryGet( 79 base::LinearHistogram::FactoryGet(
76 histogram_name, 1, int_boundary_value, bucket_count + 1, 80 histogram_name, 1, int_boundary_value, bucket_count + 1,
77 base::HistogramBase::kUmaTargetedHistogramFlag); 81 base::HistogramBase::kUmaTargetedHistogramFlag);
78 counter->Add(int_value); 82 counter->Add(int_value);
79 } 83 }
80 84
85 void MetricsHandler::HandleRecordBooleanHistogram(const base::ListValue* args) {
86 std::string histogram_name;
87 bool value;
88 if (!args->GetString(0, &histogram_name) || !args->GetBoolean(1, &value)) {
89 NOTREACHED();
90 return;
91 }
92
93 base::HistogramBase* counter = base::BooleanHistogram::FactoryGet(
94 histogram_name, base::HistogramBase::kUmaTargetedHistogramFlag);
95 counter->AddBoolean(value);
96 }
97
81 void MetricsHandler::HandleRecordTime(const base::ListValue* args) { 98 void MetricsHandler::HandleRecordTime(const base::ListValue* args) {
82 std::string histogram_name; 99 std::string histogram_name;
83 double value; 100 double value;
84 101
85 if (!args->GetString(0, &histogram_name) || 102 if (!args->GetString(0, &histogram_name) ||
86 !args->GetDouble(1, &value) || 103 !args->GetDouble(1, &value) ||
87 value < 0) { 104 value < 0) {
88 NOTREACHED(); 105 NOTREACHED();
89 return; 106 return;
90 } 107 }
(...skipping 26 matching lines...) Expand all
117 UMA_HISTOGRAM_TIMES("Tab.NewTabDOMContentLoaded", duration); 134 UMA_HISTOGRAM_TIMES("Tab.NewTabDOMContentLoaded", duration);
118 } else if (event_name == "Tab.NewTabOnload") { 135 } else if (event_name == "Tab.NewTabOnload") {
119 UMA_HISTOGRAM_TIMES("Tab.NewTabOnload", duration); 136 UMA_HISTOGRAM_TIMES("Tab.NewTabOnload", duration);
120 // The new tab page has finished loading; reset it. 137 // The new tab page has finished loading; reset it.
121 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab); 138 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);
122 core_tab_helper->set_new_tab_start_time(base::TimeTicks()); 139 core_tab_helper->set_new_tab_start_time(base::TimeTicks());
123 } else { 140 } else {
124 NOTREACHED(); 141 NOTREACHED();
125 } 142 }
126 } 143 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.h ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698