Implement important sites dialog for desktop.

chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Clear browsing data" dialog
  * to interact with the browser.
  */
 
+/**
+ * An ImportantSite represents a domain with data that the user might want
+ * to protect from being deleted. ImportantSites are determined based on
+ * various engagement factors, such as whether a site is bookmarked or receives
+ * notifications.
+ *
+ * @typedef {{
+ *   registerableDomain: string,
+ *   reasonBitfield: number,
+ *   exampleOrigin: string,
+ *   isChecked: boolean,
+ *   storageSize: number,
+ *   hasNotifications: boolean
+ * }}
+ */
+var ImportantSite;
+
+/**
+ * @typedef {{
+ *   importantSites: !Array<!ImportantSite>,
+ * }}
+ */
+var ImportantSitesResponse;

[Dan Beam, 2017/05/16 19:46:08]

why can't we just return !Array<!ImportantSite> and drop this @typedef?

[dullweber, 2017/05/17 09:57:37]

That works

+
 cr.define('settings', function() {
   /** @interface */
   function ClearBrowsingDataBrowserProxy() {}
 
   ClearBrowsingDataBrowserProxy.prototype = {
     /**
-     * @return {!Promise} A promise resolved when data clearing has completed.
+     * @param importantSites {!Array<!ImportantSite>}
+     * @return {!Promise<void>}
+     *     A promise resolved when data clearing has completed.
      */
-    clearBrowsingData: function() {},
+    clearBrowsingData: function(importantSites) {},
+
+    /**
+    * Fetches a list of important sites.

[Dan Beam, 2017/05/16 19:46:09]

ident off

[dullweber, 2017/05/17 09:57:37]

Done.

+    * @return {!Promise<!ImportantSitesResponse>}
+    *     A promise resolved when imporant sites are fetched.
+    */
+    fetchImportantSites: function() {},

[Dan Beam, 2017/05/16 19:46:09]

we have many methods that ask the C++ for data, but most of them start with get.
 can this be getImportantSites?

[dullweber, 2017/05/17 09:57:37]

sure

 
     /**
      * Kick off counter updates and return initial state.
      * @return {!Promise<void>} Signal when the setup is complete.
      */
     initialize: function() {},
   };
 
   /**
    * @constructor
    * @implements {settings.ClearBrowsingDataBrowserProxy}
    */
   function ClearBrowsingDataBrowserProxyImpl() {}
   cr.addSingletonGetter(ClearBrowsingDataBrowserProxyImpl);
 
   ClearBrowsingDataBrowserProxyImpl.prototype = {
     /** @override */
-    clearBrowsingData: function() {
-      return cr.sendWithPromise('clearBrowsingData');
+    clearBrowsingData: function(importantSites) {
+      return cr.sendWithPromise('clearBrowsingData', importantSites);
     },
 
     /** @override */
+    fetchImportantSites: function() {
+      return cr.sendWithPromise('fetchImportantSites');
+    },
+
+    /** @override */
     initialize: function() {
       return cr.sendWithPromise('initializeClearBrowsingData');
     },
   };
 
   return {
     ClearBrowsingDataBrowserProxy: ClearBrowsingDataBrowserProxy,
     ClearBrowsingDataBrowserProxyImpl: ClearBrowsingDataBrowserProxyImpl,
   };
 });