Implement important sites dialog for desktop.

chrome/test/data/webui/settings/privacy_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_privacy_page', function() {
   /**
    * @constructor
    * @extends {TestBrowserProxy}
    * @implements {settings.ClearBrowsingDataBrowserProxy}
    */
   function TestClearBrowsingDataBrowserProxy() {
-    settings.TestBrowserProxy.call(this, [
-      'initialize',
-      'clearBrowsingData',
-    ]);
+    settings.TestBrowserProxy.call(
+        this, ['initialize', 'clearBrowsingData', 'fetchImportantSites']);
 
     /**
      * The promise to return from |clearBrowsingData|.
      * Allows testing code to test what happens after the call is made, and
      * before the browser responds.
      * @private {?Promise}
      */
     this.clearBrowsingDataPromise_ = null;
+
+    /**
+     * Default response for fetchImportantSites. It tells the ui that important
+     * sites are disabled.
+     * @private {!ImportantSitesResponse}
+     */
+    this.importantSitesResponse_ = {flagEnabled: false, importantSites: []};
   }
 
   TestClearBrowsingDataBrowserProxy.prototype = {
     __proto__: settings.TestBrowserProxy.prototype,
 
     /** @param {!Promise} promise */
     setClearBrowsingDataPromise: function(promise) {
       this.clearBrowsingDataPromise_ = promise;
     },
 
     /** @override */
-    clearBrowsingData: function() {
-      this.methodCalled('clearBrowsingData');
+    clearBrowsingData: function(importantSites) {
+      this.methodCalled('clearBrowsingData', importantSites);
       cr.webUIListenerCallback('browsing-data-removing', true);
       return this.clearBrowsingDataPromise_ !== null ?
           this.clearBrowsingDataPromise_ : Promise.resolve();
     },
 
+    /** @param {!ImportantSitesResponse} response */
+    setImportantSitesResponse: function(response) {
+      this.importantSitesResponse_ = response;
+    },
+
+    /** @override */
+    fetchImportantSites: function() {
+      this.methodCalled('fetchImportantSites');
+      return Promise.resolve(this.importantSitesResponse_);
+    },
+
     /** @override */
     initialize: function() {
       this.methodCalled('initialize');
       return Promise.resolve(false);
     },
   };
 
   function registerNativeCertificateManagerTests() {
     suite('NativeCertificateManager', function() {
       /** @type {settings.TestPrivacyPageBrowserProxy} */
@@ skipping 35 matching lines @@
         assertFalse(!!page.$$('settings-clear-browsing-data-dialog'));
         MockInteractions.tap(page.$.clearBrowsingData);
         Polymer.dom.flush();
 
         var dialog = page.$$('settings-clear-browsing-data-dialog');
         assertTrue(!!dialog);
 
         // Ensure that the dialog is fully opened before returning from this
         // test, otherwise asynchronous code run in attached() can cause flaky
         // errors.
-        return test_util.whenAttributeIs(dialog.$.dialog, 'open', true);
+        return test_util.whenAttributeIs(
+            dialog.$.clearBrowsingDataDialog, 'open', true);
       });
     });
   }
 
   function registerClearBrowsingDataTests() {
     suite('ClearBrowsingData', function() {
       /** @type {settings.TestClearBrowsingDataBrowserProxy} */
       var testBrowserProxy;
 
       /** @type {SettingsClearBrowsingDataDialogElement} */
       var element;
 
       setup(function() {
         testBrowserProxy = new TestClearBrowsingDataBrowserProxy();
         settings.ClearBrowsingDataBrowserProxyImpl.instance_ = testBrowserProxy;
         PolymerTest.clearBody();
         element = document.createElement('settings-clear-browsing-data-dialog');
         document.body.appendChild(element);
-        return testBrowserProxy.whenCalled('initialize');
+        return testBrowserProxy.whenCalled('initialize').then(function() {
+          return testBrowserProxy.whenCalled('fetchImportantSites');
+        });
       });
 
       teardown(function() { element.remove(); });
 
       test('ClearBrowsingDataTap', function() {
-        assertTrue(element.$.dialog.open);
+        assertTrue(element.$.clearBrowsingDataDialog.open);
+        assertFalse(element.$.importantSitesDialog.open);
+        assertFalse(element.importantSitesFlagEnabled_);
 
         var cancelButton = element.$$('.cancel-button');
         assertTrue(!!cancelButton);
         var actionButton = element.$$('.action-button');
         assertTrue(!!actionButton);
         var spinner = element.$$('paper-spinner');
         assertTrue(!!spinner);
 
         assertFalse(cancelButton.disabled);
         assertFalse(actionButton.disabled);
         assertFalse(spinner.active);
 
         var promiseResolver = new PromiseResolver();
         testBrowserProxy.setClearBrowsingDataPromise(promiseResolver.promise);
         MockInteractions.tap(actionButton);
 
-        return testBrowserProxy.whenCalled('clearBrowsingData').then(
-            function() {
-              assertTrue(element.$.dialog.open);
+        return testBrowserProxy.whenCalled('clearBrowsingData')
+            .then(function(importantSites) {
+              assertTrue(element.$.clearBrowsingDataDialog.open);
               assertTrue(cancelButton.disabled);
               assertTrue(actionButton.disabled);
               assertTrue(spinner.active);
+              assertTrue(importantSites.length == 0);
 
               // Simulate signal from browser indicating that clearing has
               // completed.
               cr.webUIListenerCallback('browsing-data-removing', false);
               promiseResolver.resolve();
               // Yields to the message loop to allow the callback chain of the
               // Promise that was just resolved to execute before the
               // assertions.
-            }).then(function() {
-              assertFalse(element.$.dialog.open);
+            })
+            .then(function() {
+              assertFalse(element.$.clearBrowsingDataDialog.open);
               assertFalse(cancelButton.disabled);
               assertFalse(actionButton.disabled);
               assertFalse(spinner.active);
               assertFalse(!!element.$$('#notice'));
+              // Check that the dialog didn't switch to important sites.
+              assertFalse(element.$.importantSitesDialog.open);
             });
       });
 
       test('showHistoryDeletionDialog', function() {
-        assertTrue(element.$.dialog.open);
+        assertTrue(element.$.clearBrowsingDataDialog.open);
         var actionButton = element.$$('.action-button');
         assertTrue(!!actionButton);
 
         var promiseResolver = new PromiseResolver();
         testBrowserProxy.setClearBrowsingDataPromise(promiseResolver.promise);
         MockInteractions.tap(actionButton);
 
         return testBrowserProxy.whenCalled('clearBrowsingData').then(
             function() {
               // Passing showNotice = true should trigger the notice about other
               // forms of browsing history to open, and the dialog to stay open.
               promiseResolver.resolve(true /* showNotice */);
 
               // Yields to the message loop to allow the callback chain of the
               // Promise that was just resolved to execute before the
               // assertions.
             }).then(function() {
               Polymer.dom.flush();
               var notice = element.$$('#notice');
               assertTrue(!!notice);
               var noticeActionButton = notice.$$('.action-button');
               assertTrue(!!noticeActionButton);
 
-              assertTrue(element.$.dialog.open);
+              assertTrue(element.$.clearBrowsingDataDialog.open);
               assertTrue(notice.$.dialog.open);
 
               MockInteractions.tap(noticeActionButton);
 
               return new Promise(function(resolve, reject) {
                 // Tapping the action button will close the notice. Move to the
                 // end of the message loop to allow the closing event to
                 // propagate to the parent dialog. The parent dialog should
                 // subsequently close as well.
                 setTimeout(function() {
                   var notice = element.$$('#notice');
                   assertFalse(!!notice);
-                  assertFalse(element.$.dialog.open);
+                  assertFalse(element.$.clearBrowsingDataDialog.open);
                   resolve();
                 }, 0);
               });
             });
       });
 
       test('Counters', function() {
-        assertTrue(element.$.dialog.open);
+        assertTrue(element.$.clearBrowsingDataDialog.open);
 
         // Initialize the browsing history pref, which should belong to the
         // first checkbox in the dialog.
         element.set('prefs', {
           browser: {
             clear_data: {
               browsing_history: {
                 key: 'browser.clear_data.browsing_history',
                 type: chrome.settingsPrivate.PrefType.BOOLEAN,
                 value: true,
               }
             }
           }
         });
         var checkbox = element.$$('settings-checkbox');
         assertEquals('browser.clear_data.browsing_history', checkbox.pref.key);
 
         // Simulate a browsing data counter result for history. This checkbox's
         // sublabel should be updated.
         cr.webUIListenerCallback(
             'update-counter-text', checkbox.pref.key, 'result');
         assertEquals('result', checkbox.subLabel);
       });
     });
   }
 
+  suite('ImportantSites', function() {
+    /** @type {settings.TestClearBrowsingDataBrowserProxy} */
+    var testBrowserProxy;
+
+    /** @type {SettingsClearBrowsingDataDialogElement} */
+    var element;
+
+    /** @type {Array<ImportantSite>} */
+    var importantSites = [
+      {registerableDomain: 'google.com', isChecked: true},
+      {registerableDomain: 'yahoo.com', isChecked: true}
+    ]

[Dan Beam, 2017/05/09 19:23:18]

] -> ];

[dullweber, 2017/05/11 13:13:48]

Done.

+
+    setup(function() {
+      testBrowserProxy = new TestClearBrowsingDataBrowserProxy();
+      testBrowserProxy.setImportantSitesResponse({
+        flagEnabled: true,
+        importantSites: importantSites,
+      });
+      settings.ClearBrowsingDataBrowserProxyImpl.instance_ = testBrowserProxy;
+      PolymerTest.clearBody();
+      element = document.createElement('settings-clear-browsing-data-dialog');
+      document.body.appendChild(element);
+      return testBrowserProxy.whenCalled('initialize').then(function() {
+        return testBrowserProxy.whenCalled('fetchImportantSites');
+      });
+    });
+
+    teardown(function() {
+      element.remove();
+    });
+
+    test('fetchImportantSites', function() {
+      assertTrue(element.$.clearBrowsingDataDialog.open);
+      assertFalse(element.$.importantSitesDialog.open);
+      // Select an entry that can have important storage.
+      element.$.cookiesCheckbox.checked = true;
+      // Clear browsing data.
+      MockInteractions.tap(element.$.clearBrowsingDataConfirm);
+      assertFalse(element.$.clearBrowsingDataDialog.open);
+      assertTrue(element.$.importantSitesDialog.open);
+
+      Polymer.dom.flush();
+      var firstImportantSite = element.$$('important-site-checkbox')
+      assertTrue(!!firstImportantSite);
+      assertEquals(firstImportantSite.site.registerableDomain, 'google.com');
+      assertTrue(firstImportantSite.site.isChecked)
+      // Choose to keep storage for google.com.
+      MockInteractions.tap(firstImportantSite.$.checkbox);
+      assertFalse(firstImportantSite.site.isChecked)
+      // Confirm deletion.
+      MockInteractions.tap(element.$.importantSitesConfirm);
+      return testBrowserProxy.whenCalled('clearBrowsingData')
+          .then(function(sites) {
+            assertEquals(sites.length, 2);
+            assertEquals(sites[0].registerableDomain, 'google.com');
+            assertFalse(sites[0].isChecked);
+            assertEquals(sites[1].registerableDomain, 'yahoo.com');
+            assertTrue(sites[1].isChecked);
+          });
+    });
+  });
+
   function registerSafeBrowsingExtendedReportingTests() {
     suite('SafeBrowsingExtendedReporting', function() {
       /** @type {settings.TestPrivacyPageBrowserProxy} */
       var testBrowserProxy;
 
       /** @type {SettingsPrivacyPageElement} */
       var page;
 
       setup(function() {
         testBrowserProxy = new TestPrivacyPageBrowserProxy();
@@ skipping 32 matching lines @@
     registerTests: function() {
       if (cr.isMac || cr.isWin)
         registerNativeCertificateManagerTests();
 
       registerClearBrowsingDataTests();
       registerPrivacyPageTests();
       registerSafeBrowsingExtendedReportingTests();
     },
   };
 });