Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Side by Side Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: fix comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/chrome_feature_list.h" 5 #include "chrome/browser/android/chrome_feature_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 21 matching lines...) Expand all
32 32
33 namespace { 33 namespace {
34 34
35 // Array of features exposed through the Java ChromeFeatureList API. Entries in 35 // Array of features exposed through the Java ChromeFeatureList API. Entries in
36 // this array may either refer to features defined in the header of this file or 36 // this array may either refer to features defined in the header of this file or
37 // in other locations in the code base (e.g. chrome/, components/, etc). 37 // in other locations in the code base (e.g. chrome/, components/, etc).
38 const base::Feature* kFeaturesExposedToJava[] = { 38 const base::Feature* kFeaturesExposedToJava[] = {
39 &autofill::kAutofillScanCardholderName, 39 &autofill::kAutofillScanCardholderName,
40 &features::kConsistentOmniboxGeolocation, 40 &features::kConsistentOmniboxGeolocation,
41 &features::kCopylessPaste, 41 &features::kCopylessPaste,
42 &features::kImportantSitesInCbd,
42 &features::kNativeAndroidHistoryManager, 43 &features::kNativeAndroidHistoryManager,
43 &features::kServiceWorkerPaymentApps, 44 &features::kServiceWorkerPaymentApps,
44 &features::kSimplifiedFullscreenUI, 45 &features::kSimplifiedFullscreenUI,
45 &features::kVrShell, 46 &features::kVrShell,
46 &features::kWebPayments, 47 &features::kWebPayments,
47 &features::kTabsInCbd, 48 &features::kTabsInCbd,
48 &kAndroidPayIntegrationV1, 49 &kAndroidPayIntegrationV1,
49 &kAndroidPayIntegrationV2, 50 &kAndroidPayIntegrationV2,
50 &kAndroidPaymentApps, 51 &kAndroidPaymentApps,
51 &kCCTBackgroundTab, 52 &kCCTBackgroundTab,
52 &kCCTExternalLinkHandling, 53 &kCCTExternalLinkHandling,
53 &kCCTPostMessageAPI, 54 &kCCTPostMessageAPI,
54 &kChromeHomeFeature, 55 &kChromeHomeFeature,
55 &kChromeHomeExpandButton, 56 &kChromeHomeExpandButton,
56 &kContentSuggestionsSettings, 57 &kContentSuggestionsSettings,
57 &kContextualSearchSingleActions, 58 &kContextualSearchSingleActions,
58 &kContextualSearchUrlActions, 59 &kContextualSearchUrlActions,
59 &kCustomContextMenu, 60 &kCustomContextMenu,
60 &kCustomFeedbackUi, 61 &kCustomFeedbackUi,
61 &data_reduction_proxy::features::kDataReductionMainMenu, 62 &data_reduction_proxy::features::kDataReductionMainMenu,
62 &data_reduction_proxy::features::kDataReductionSiteBreakdown, 63 &data_reduction_proxy::features::kDataReductionSiteBreakdown,
63 &kFullscreenActivity, 64 &kFullscreenActivity,
64 &kImportantSitesInCBD,
65 &kImprovedA2HS, 65 &kImprovedA2HS,
66 &kNewPhotoPicker, 66 &kNewPhotoPicker,
67 &kNoCreditCardAbort, 67 &kNoCreditCardAbort,
68 &kNTPCondensedLayoutFeature, 68 &kNTPCondensedLayoutFeature,
69 &kNTPCondensedTileLayoutFeature, 69 &kNTPCondensedTileLayoutFeature,
70 &kNTPLaunchAfterInactivity, 70 &kNTPLaunchAfterInactivity,
71 &kNTPOfflinePagesFeature, 71 &kNTPOfflinePagesFeature,
72 &NTPShowGoogleGInOmniboxFeature, 72 &NTPShowGoogleGInOmniboxFeature,
73 &kPhysicalWebFeature, 73 &kPhysicalWebFeature,
74 &kPhysicalWebSharing, 74 &kPhysicalWebSharing,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 143
144 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi", 144 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi",
145 base::FEATURE_DISABLED_BY_DEFAULT}; 145 base::FEATURE_DISABLED_BY_DEFAULT};
146 146
147 const base::Feature kDownloadAutoResumptionThrottling{ 147 const base::Feature kDownloadAutoResumptionThrottling{
148 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT}; 148 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT};
149 149
150 const base::Feature kFullscreenActivity{"FullscreenActivity", 150 const base::Feature kFullscreenActivity{"FullscreenActivity",
151 base::FEATURE_DISABLED_BY_DEFAULT}; 151 base::FEATURE_DISABLED_BY_DEFAULT};
152 152
153 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
154 base::FEATURE_DISABLED_BY_DEFAULT};
155
156 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut 153 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut
157 // URL which opens Chrome in fullscreen. 154 // URL which opens Chrome in fullscreen.
158 const base::Feature kImprovedA2HS{"ImprovedA2HS", 155 const base::Feature kImprovedA2HS{"ImprovedA2HS",
159 base::FEATURE_DISABLED_BY_DEFAULT}; 156 base::FEATURE_DISABLED_BY_DEFAULT};
160 157
161 const base::Feature kSearchEnginePromoExistingDevice{ 158 const base::Feature kSearchEnginePromoExistingDevice{
162 "SearchEnginePromo.ExistingDevice", base::FEATURE_DISABLED_BY_DEFAULT}; 159 "SearchEnginePromo.ExistingDevice", base::FEATURE_DISABLED_BY_DEFAULT};
163 160
164 const base::Feature kSearchEnginePromoNewDevice{ 161 const base::Feature kSearchEnginePromoNewDevice{
165 "SearchEnginePromo.NewDevice", base::FEATURE_DISABLED_BY_DEFAULT}; 162 "SearchEnginePromo.NewDevice", base::FEATURE_DISABLED_BY_DEFAULT};
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name, 278 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name,
282 jdefault_value); 279 jdefault_value);
283 } 280 }
284 281
285 bool RegisterChromeFeatureListJni(JNIEnv* env) { 282 bool RegisterChromeFeatureListJni(JNIEnv* env) {
286 return RegisterNativesImpl(env); 283 return RegisterNativesImpl(env);
287 } 284 }
288 285
289 } // namespace android 286 } // namespace android
290 } // namespace chrome 287 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698