Implement important sites dialog for desktop.

chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner.html">
 <link rel="import" href="../i18n_setup.html">
 <link rel="import" href="clear_browsing_data_browser_proxy.html">
 <link rel="import" href="history_deletion_dialog.html">
+<link rel="import" href="../controls/important_site_checkbox.html">
 <link rel="import" href="../controls/settings_checkbox.html">
 <link rel="import" href="../controls/settings_dropdown_menu.html">
 <link rel="import" href="../icons.html">
 <link rel="import" href="../settings_shared_css.html">
 
 <dom-module id="settings-clear-browsing-data-dialog">
   <template>
     <style include="settings-shared">
-      #dialog:not(.fully-rendered) {
+      #clearBrowsingDataDialog:not(.fully-rendered) {
         visibility: hidden;
       }
 
-      #dialog .footer {
+      #clearBrowsingDataDialog .footer {
         color: var(--paper-grey-600);
       }
 
       .row {
         align-items: center;
         display: flex;
         min-height: 40px;
       }
 
       paper-spinner {
@@ skipping 47 matching lines @@
       }
 
       .clear-browsing-data-footer a {
         text-decoration: none;
       }
 
       #clearFrom {
         -webkit-margin-start: 0.5em;
       }
 
+      .title .secondary {
+        font-size: calc(13 / 15 * 100%);
+        padding-top: 8px;
+      }
+
       /* Cap the height on smaller screens to avoid unfavorable clipping.
        * Replace the bottom margin with padding to avoid the gap between
        * the scrollbar and the bottom separator. */
       @media all and (max-height: 724px) {
-        #dialog {
+        #clearBrowsingDataDialog {
           /* crbug.com/652027: Show four and a *half* items in the list. */
           --cr-dialog-body-container: {
-            max-height: 280px; 
+            max-height: 280px;
           };
         }
       }
     </style>
 
-    <dialog is="cr-dialog" id="dialog" close-text="$i18n{close}"
-        ignore-popstate>
+    <dialog is="cr-dialog" id="clearBrowsingDataDialog"
+        on-close="onClearBrowsingDataDialogClose_"
+        close-text="$i18n{close}" ignore-popstate>
       <div class="title">$i18n{clearBrowsingData}</div>
       <div class="body">
         <div class="row">
           $i18n{clearFollowingItemsFrom}
           <settings-dropdown-menu id="clearFrom"
               label="$i18n{clearFollowingItemsFrom}"
               pref="{{prefs.browser.clear_data.time_period}}"
               menu-options="[[clearFromOptions_]]">
           </settings-dropdown-menu>
         </div>
         <settings-checkbox id="browsingCheckbox"
             pref="{{prefs.browser.clear_data.browsing_history}}"
             label="$i18n{clearBrowsingHistory}"
             sub-label="[[counters_.browsing_history]]"
             disabled="[[clearingInProgress_]]">
         </settings-checkbox>
         <settings-checkbox id="downloadCheckbox"
             pref="{{prefs.browser.clear_data.download_history}}"
             label="$i18n{clearDownloadHistory}"
             sub-label="[[counters_.download_history]]"
             disabled="[[clearingInProgress_]]">
         </settings-checkbox>
-        <settings-checkbox
+        <settings-checkbox id="cacheCheckbox"
             pref="{{prefs.browser.clear_data.cache}}"
             label="$i18n{clearCache}"
             sub-label="[[counters_.cache]]"
             disabled="[[clearingInProgress_]]">
         </settings-checkbox>
-        <settings-checkbox
+        <settings-checkbox id="cookiesCheckbox"
             pref="{{prefs.browser.clear_data.cookies}}"
             label="$i18n{clearCookies}"
             sub-label="$i18n{clearCookiesCounter}"
             disabled="[[clearingInProgress_]]">
         </settings-checkbox>
         <settings-checkbox
             pref="{{prefs.browser.clear_data.passwords}}"
             label="$i18n{clearPasswords}"
             sub-label="[[counters_.passwords]]"
             disabled="[[clearingInProgress_]]">
@@ skipping 14 matching lines @@
             pref="{{prefs.browser.clear_data.media_licenses}}"
             label="$i18n{clearMediaLicenses}"
             sub-label="[[counters_.media_licenses]]"
             disabled="[[clearingInProgress_]]">
         </settings-checkbox>
       </div>
       <div class="button-container">
         <paper-spinner active="[[clearingInProgress_]]"></paper-spinner>
         <paper-button class="cancel-button" disabled="[[clearingInProgress_]]"
             on-tap="onCancelTap_">$i18n{cancel}</paper-button>
-        <paper-button class="action-button" disabled="[[clearingInProgress_]]"
+        <paper-button id="clearBrowsingDataConfirm"
+            class="action-button" disabled="[[clearingInProgress_]]"
             on-tap="onClearBrowsingDataTap_">
-          $i18n{clearBrowsingData}
+            $i18n{clearBrowsingData}
         </paper-button>
       </div>
       <div class="footer">
         <div id="googleFooter" class="clear-browsing-data-footer">
           <iron-icon icon="settings:googleg"></iron-icon>
           <div class="footer-text">$i18nRaw{otherFormsOfBrowsingHistory}</div>
         </div>
         <div id="generalFooter" class="clear-browsing-data-footer">
           <iron-icon icon="settings:info"></iron-icon>
           <div class="footer-text">
             <span id="syncedDataSentence">$i18n{clearsSyncedData}</span>
             <span>$i18n{warnAboutNonClearedData}</span>
             <a id="clear-browser-data-old-learn-more-link"
                 href="$i18n{clearBrowsingDataLearnMoreUrl}"
                 target="_blank">$i18n{learnMore}</a>
           </div>
         </div>
       </div>
     </dialog>
 
+    <dialog is="cr-dialog" id="importantSitesDialog" close-text="$i18n{close}"

[Dan Beam, 2017/05/05 17:52:50]

does this need to be in the same file?

why isn't it behind an dom-if?

[dullweber, 2017/05/09 08:56:39]

It doesn't need to be in the same file but it reduces duplication between the
dialog and the clearBrowsingDataDialog because both dialogs have to access
clearingInProgress_ and both might have to call clearBrowsingData_() when
confirmed.

I can put the dialog behind a dom-if. What is the advantage? Doesn't the dialog
already handle this itself by being hidden until dialog.open() is called?

[Dan Beam, 2017/05/09 19:25:03]

it potentially slows down showing the clear browsing data dialog

[dullweber, 2017/05/11 13:13:42]

ok, I moved the dialog into a dom-if

+        show-scroll-borders ignore-popstate>
+      <div class="title">
+        $i18n{clearBrowsingData}
+        <div class="secondary">
+          $i18n{importantSitesSubtitle}
+        </div>
+      </div>
+      <div class="body">
+        <template is="dom-repeat" items="[[importantSites_]]">
+          <div class="row">
+            <important-site-checkbox
+                site="[[item]]"
+                disabled="[[clearingInProgress_]]">
+            </important-site-checkbox>
+          </div>
+        </template>
+      </div>
+      <div class="button-container">
+        <paper-spinner active="[[clearingInProgress_]]"></paper-spinner>
+        <paper-button class="cancel-button" disabled="[[clearingInProgress_]]"
+            on-tap="onImportantSitesCancelTap_">$i18n{cancel}</paper-button>
+        <paper-button id="importantSitesConfirm"
+            class="action-button" disabled="[[clearingInProgress_]]"
+            on-tap="onImportantSitesConfirmTap_">
+            $i18n{importantSitesConfirm}
+        </paper-button>
+      </div>
+    </dialog>
+
     <template is="dom-if" if="[[showHistoryDeletionDialog_]]" restamp>
       <settings-history-deletion-dialog id="notice"
           on-close="onHistoryDeletionDialogClose_">
       </settings-history-deletion-dialog>
     </template>
   </template>
   <script src="clear_browsing_data_dialog.js"></script>
 </dom-module>