Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: fix comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h" 5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <vector>
8 9
10 #include "base/feature_list.h"
9 #include "base/macros.h" 11 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
11 #include "base/metrics/histogram_macros.h" 13 #include "base/metrics/histogram_macros.h"
12 #include "base/metrics/sparse_histogram.h" 14 #include "base/metrics/sparse_histogram.h"
15 #include "base/values.h"
13 #include "chrome/browser/browsing_data/browsing_data_counter_factory.h" 16 #include "chrome/browser/browsing_data/browsing_data_counter_factory.h"
14 #include "chrome/browser/browsing_data/browsing_data_counter_utils.h" 17 #include "chrome/browser/browsing_data/browsing_data_counter_utils.h"
15 #include "chrome/browser/browsing_data/browsing_data_helper.h" 18 #include "chrome/browser/browsing_data/browsing_data_helper.h"
19 #include "chrome/browser/browsing_data/browsing_data_important_sites_util.h"
16 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h" 20 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
21 #include "chrome/browser/engagement/important_sites_util.h"
17 #include "chrome/browser/history/web_history_service_factory.h" 22 #include "chrome/browser/history/web_history_service_factory.h"
18 #include "chrome/browser/sync/profile_sync_service_factory.h" 23 #include "chrome/browser/sync/profile_sync_service_factory.h"
19 #include "chrome/common/channel_info.h" 24 #include "chrome/common/channel_info.h"
25 #include "chrome/common/chrome_features.h"
20 #include "chrome/common/pref_names.h" 26 #include "chrome/common/pref_names.h"
21 #include "components/browsing_data/core/history_notice_utils.h" 27 #include "components/browsing_data/core/history_notice_utils.h"
22 #include "components/browsing_data/core/pref_names.h" 28 #include "components/browsing_data/core/pref_names.h"
23 #include "components/prefs/pref_service.h" 29 #include "components/prefs/pref_service.h"
30 #include "content/public/browser/browsing_data_filter_builder.h"
24 #include "content/public/browser/web_ui.h" 31 #include "content/public/browser/web_ui.h"
32 #include "ui/base/text/bytes_formatting.h"
33
34 using ImportantReason = ImportantSitesUtil::ImportantReason;
25 35
26 namespace { 36 namespace {
27 37
28 const int kMaxTimesHistoryNoticeShown = 1; 38 const int kMaxTimesHistoryNoticeShown = 1;
29 39
40 const int kMaxImportantSites = 10;
41
30 // TODO(msramek): Get the list of deletion preferences from the JS side. 42 // TODO(msramek): Get the list of deletion preferences from the JS side.
31 const char* kCounterPrefs[] = { 43 const char* kCounterPrefs[] = {
32 browsing_data::prefs::kDeleteBrowsingHistory, 44 browsing_data::prefs::kDeleteBrowsingHistory,
33 browsing_data::prefs::kDeleteCache, 45 browsing_data::prefs::kDeleteCache,
34 browsing_data::prefs::kDeleteDownloadHistory, 46 browsing_data::prefs::kDeleteDownloadHistory,
35 browsing_data::prefs::kDeleteFormData, 47 browsing_data::prefs::kDeleteFormData,
36 browsing_data::prefs::kDeleteHostedAppsData, 48 browsing_data::prefs::kDeleteHostedAppsData,
37 browsing_data::prefs::kDeleteMediaLicenses, 49 browsing_data::prefs::kDeleteMediaLicenses,
38 browsing_data::prefs::kDeletePasswords, 50 browsing_data::prefs::kDeletePasswords,
39 }; 51 };
40 52
53 const char kRegisterableDomainField[] = "registerableDomain";
54 const char kReasonBitField[] = "reasonBitfield";
55 const char kExampleOriginField[] = "exampleOrigin";
56 const char kFlagEnabledField[] = "flagEnabled";
57 const char kImportantSitesField[] = "importantSites";
58 const char kIsCheckedField[] = "isChecked";
59 const char kStorageSizeField[] = "storageSize";
60 const char kHasNotificationsField[] = "hasNotifications";
61
41 } // namespace 62 } // namespace
42 63
43 namespace settings { 64 namespace settings {
44 65
45 // TaskObserver ---------------------------------------------------------------- 66 // TaskObserver ----------------------------------------------------------------
46 67
47 class ClearBrowsingDataHandler::TaskObserver 68 class ClearBrowsingDataHandler::TaskObserver
48 : public content::BrowsingDataRemover::Observer { 69 : public content::BrowsingDataRemover::Observer {
49 public: 70 public:
50 TaskObserver(content::BrowsingDataRemover* remover, 71 TaskObserver(content::BrowsingDataRemover* remover,
51 const base::Closure& callback); 72 const base::Closure& callback,
73 int task_count);
52 ~TaskObserver() override; 74 ~TaskObserver() override;
53 75
54 void OnBrowsingDataRemoverDone() override; 76 void OnBrowsingDataRemoverDone() override;
55 77
56 private: 78 private:
57 base::Closure callback_; 79 base::Closure callback_;
58 ScopedObserver<content::BrowsingDataRemover, 80 ScopedObserver<content::BrowsingDataRemover,
59 content::BrowsingDataRemover::Observer> 81 content::BrowsingDataRemover::Observer>
60 remover_observer_; 82 remover_observer_;
83 int task_count_;
61 84
62 DISALLOW_COPY_AND_ASSIGN(TaskObserver); 85 DISALLOW_COPY_AND_ASSIGN(TaskObserver);
63 }; 86 };
64 87
65 ClearBrowsingDataHandler::TaskObserver::TaskObserver( 88 ClearBrowsingDataHandler::TaskObserver::TaskObserver(
66 content::BrowsingDataRemover* remover, 89 content::BrowsingDataRemover* remover,
67 const base::Closure& callback) 90 const base::Closure& callback,
68 : callback_(callback), remover_observer_(this) { 91 int task_count)
92 : callback_(callback), remover_observer_(this), task_count_(task_count) {
69 remover_observer_.Add(remover); 93 remover_observer_.Add(remover);
70 } 94 }
71 95
72 ClearBrowsingDataHandler::TaskObserver::~TaskObserver() {} 96 ClearBrowsingDataHandler::TaskObserver::~TaskObserver() {}
73 97
74 void ClearBrowsingDataHandler::TaskObserver::OnBrowsingDataRemoverDone() { 98 void ClearBrowsingDataHandler::TaskObserver::OnBrowsingDataRemoverDone() {
99 DCHECK(task_count_);
100 if (--task_count_)
101 return;
75 remover_observer_.RemoveAll(); 102 remover_observer_.RemoveAll();
76 callback_.Run(); 103 callback_.Run();
77 } 104 }
78 105
79 // ClearBrowsingDataHandler ---------------------------------------------------- 106 // ClearBrowsingDataHandler ----------------------------------------------------
80 107
81 ClearBrowsingDataHandler::ClearBrowsingDataHandler(content::WebUI* webui) 108 ClearBrowsingDataHandler::ClearBrowsingDataHandler(content::WebUI* webui)
82 : profile_(Profile::FromWebUI(webui)), 109 : profile_(Profile::FromWebUI(webui)),
83 sync_service_(ProfileSyncServiceFactory::GetForProfile(profile_)), 110 sync_service_(ProfileSyncServiceFactory::GetForProfile(profile_)),
84 sync_service_observer_(this), 111 sync_service_observer_(this),
85 show_history_footer_(false), 112 show_history_footer_(false),
86 show_history_deletion_dialog_(false), 113 show_history_deletion_dialog_(false),
87 weak_ptr_factory_(this) {} 114 weak_ptr_factory_(this) {}
88 115
89 ClearBrowsingDataHandler::~ClearBrowsingDataHandler() { 116 ClearBrowsingDataHandler::~ClearBrowsingDataHandler() {
90 } 117 }
91 118
92 void ClearBrowsingDataHandler::RegisterMessages() { 119 void ClearBrowsingDataHandler::RegisterMessages() {
93 web_ui()->RegisterMessageCallback( 120 web_ui()->RegisterMessageCallback(
94 "clearBrowsingData", 121 "clearBrowsingData",
95 base::Bind(&ClearBrowsingDataHandler::HandleClearBrowsingData, 122 base::Bind(&ClearBrowsingDataHandler::HandleClearBrowsingData,
96 base::Unretained(this))); 123 base::Unretained(this)));
97 124
98 web_ui()->RegisterMessageCallback( 125 web_ui()->RegisterMessageCallback(
126 "fetchImportantSites",
127 base::Bind(&ClearBrowsingDataHandler::HandleFetchImportantSites,
128 base::Unretained(this)));
129
130 web_ui()->RegisterMessageCallback(
99 "initializeClearBrowsingData", 131 "initializeClearBrowsingData",
100 base::Bind(&ClearBrowsingDataHandler::HandleInitialize, 132 base::Bind(&ClearBrowsingDataHandler::HandleInitialize,
101 base::Unretained(this))); 133 base::Unretained(this)));
102 } 134 }
103 135
104 void ClearBrowsingDataHandler::OnJavascriptAllowed() { 136 void ClearBrowsingDataHandler::OnJavascriptAllowed() {
105 if (sync_service_) 137 if (sync_service_)
106 sync_service_observer_.Add(sync_service_); 138 sync_service_observer_.Add(sync_service_);
107 139
108 DCHECK(counters_.empty()); 140 DCHECK(counters_.empty());
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 [prefs](const std::string& pref) { return prefs->GetBoolean(pref); }); 224 [prefs](const std::string& pref) { return prefs->GetBoolean(pref); });
193 UMA_HISTOGRAM_SPARSE_SLOWLY( 225 UMA_HISTOGRAM_SPARSE_SLOWLY(
194 "History.ClearBrowsingData.PasswordsDeletion.AdditionalDatatypesCount", 226 "History.ClearBrowsingData.PasswordsDeletion.AdditionalDatatypesCount",
195 checked_other_types); 227 checked_other_types);
196 } 228 }
197 229
198 int period_selected = 230 int period_selected =
199 prefs->GetInteger(browsing_data::prefs::kDeleteTimePeriod); 231 prefs->GetInteger(browsing_data::prefs::kDeleteTimePeriod);
200 232
201 std::string webui_callback_id; 233 std::string webui_callback_id;
202 CHECK_EQ(1U, args->GetSize()); 234 CHECK_EQ(2U, args->GetSize());
203 CHECK(args->GetString(0, &webui_callback_id)); 235 CHECK(args->GetString(0, &webui_callback_id));
204 236
237 const base::ListValue* important_sites = nullptr;
238 CHECK(args->GetList(1, &important_sites));
239 std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder =
240 ProcessImportantSites(important_sites);
241
205 content::BrowsingDataRemover* remover = 242 content::BrowsingDataRemover* remover =
206 content::BrowserContext::GetBrowsingDataRemover(profile_); 243 content::BrowserContext::GetBrowsingDataRemover(profile_);
207 task_observer_ = base::MakeUnique<TaskObserver>( 244 task_observer_ = base::MakeUnique<TaskObserver>(
208 remover, 245 remover,
209 base::Bind(&ClearBrowsingDataHandler::OnClearingTaskFinished, 246 base::Bind(&ClearBrowsingDataHandler::OnClearingTaskFinished,
210 base::Unretained(this), webui_callback_id)); 247 base::Unretained(this), webui_callback_id),
248 /*task_count=*/2);
211 browsing_data::TimePeriod time_period = 249 browsing_data::TimePeriod time_period =
212 static_cast<browsing_data::TimePeriod>(period_selected); 250 static_cast<browsing_data::TimePeriod>(period_selected);
213 browsing_data::RecordDeletionForPeriod(time_period); 251
214 remover->RemoveAndReply( 252 browsing_data_important_sites_util::Remove(
215 browsing_data::CalculateBeginDeleteTime(time_period), 253 remove_mask, origin_mask, time_period, std::move(filter_builder), remover,
216 browsing_data::CalculateEndDeleteTime(time_period), 254 task_observer_.get());
217 remove_mask, origin_mask, task_observer_.get()); 255 }
256
257 std::unique_ptr<content::BrowsingDataFilterBuilder>
258 ClearBrowsingDataHandler::ProcessImportantSites(
259 const base::ListValue* important_sites) {
260 std::vector<std::string> excluding_domains;
261 std::vector<int32_t> excluding_domain_reasons;
262 std::vector<std::string> ignoring_domains;
263 std::vector<int32_t> ignoring_domain_reasons;
264 for (const auto& item : *important_sites) {
265 const base::DictionaryValue* site = nullptr;
266 CHECK(item.GetAsDictionary(&site));
267 bool is_checked = false;
268 CHECK(site->GetBoolean(kIsCheckedField, &is_checked));
269 std::string domain;
270 CHECK(site->GetString(kRegisterableDomainField, &domain));
271 int domain_reason = -1;
272 CHECK(site->GetInteger(kReasonBitField, &domain_reason));
273 if (is_checked) { // Selected important sites should be deleted.
274 ignoring_domains.push_back(domain);
275 ignoring_domain_reasons.push_back(domain_reason);
276 } else { // Unselected sites should be kept.
277 excluding_domains.push_back(domain);
278 excluding_domain_reasons.push_back(domain_reason);
279 }
280 }
281
282 if (!excluding_domains.empty() || !ignoring_domains.empty()) {
283 ImportantSitesUtil::RecordBlacklistedAndIgnoredImportantSites(
284 profile_->GetOriginalProfile(), excluding_domains,
285 excluding_domain_reasons, ignoring_domains, ignoring_domain_reasons);
286 }
287
288 std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder(
289 content::BrowsingDataFilterBuilder::Create(
290 content::BrowsingDataFilterBuilder::BLACKLIST));
291 for (const std::string& domain : excluding_domains) {
292 filter_builder->AddRegisterableDomain(domain);
293 }
294 return filter_builder;
218 } 295 }
219 296
220 void ClearBrowsingDataHandler::OnClearingTaskFinished( 297 void ClearBrowsingDataHandler::OnClearingTaskFinished(
221 const std::string& webui_callback_id) { 298 const std::string& webui_callback_id) {
222 PrefService* prefs = profile_->GetPrefs(); 299 PrefService* prefs = profile_->GetPrefs();
223 int notice_shown_times = prefs->GetInteger( 300 int notice_shown_times = prefs->GetInteger(
224 browsing_data::prefs::kClearBrowsingDataHistoryNoticeShownTimes); 301 browsing_data::prefs::kClearBrowsingDataHistoryNoticeShownTimes);
225 302
226 // When the deletion is complete, we might show an additional dialog with 303 // When the deletion is complete, we might show an additional dialog with
227 // a notice about other forms of browsing history. This is the case if 304 // a notice about other forms of browsing history. This is the case if
(...skipping 13 matching lines...) Expand all
241 } 318 }
242 319
243 UMA_HISTOGRAM_BOOLEAN( 320 UMA_HISTOGRAM_BOOLEAN(
244 "History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice); 321 "History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
245 322
246 ResolveJavascriptCallback(base::Value(webui_callback_id), 323 ResolveJavascriptCallback(base::Value(webui_callback_id),
247 base::Value(show_notice)); 324 base::Value(show_notice));
248 task_observer_.reset(); 325 task_observer_.reset();
249 } 326 }
250 327
328 void ClearBrowsingDataHandler::HandleFetchImportantSites(
329 const base::ListValue* args) {
330 AllowJavascript();
331 const base::Value* callback_id;
332 CHECK(args->Get(0, &callback_id));
333
334 bool important_sites_flag_enabled =
335 base::FeatureList::IsEnabled(features::kImportantSitesInCbd);
336 Profile* profile = profile_->GetOriginalProfile();
337 bool important_sites_dialog_disabled =
338 ImportantSitesUtil::IsDialogDisabled(profile);
339 auto important_sites_list = base::MakeUnique<base::ListValue>();
340
341 if (important_sites_flag_enabled && !important_sites_dialog_disabled) {
342 std::vector<ImportantSitesUtil::ImportantDomainInfo> important_sites =
343 ImportantSitesUtil::GetImportantRegisterableDomains(profile,
344 kMaxImportantSites);
345 for (const auto& info : important_sites) {
346 auto entry = base::MakeUnique<base::DictionaryValue>();
347 entry->SetString(kRegisterableDomainField, info.registerable_domain);
348 // The |reason_bitfield| is only passed to Javascript to be logged
349 // from |HandleClearBrowsingData|.
350 entry->SetInteger(kReasonBitField, info.reason_bitfield);
351 entry->SetString(kExampleOriginField, info.example_origin.spec());
352 // Initially all sites are selected for deletion.
353 entry->SetBoolean(kIsCheckedField, true);
354 // TODO(dullweber): Get size.
355 entry->SetString(kStorageSizeField, ui::FormatBytes(0));
356 bool has_notifications =
357 (info.reason_bitfield & (1 << ImportantReason::NOTIFICATIONS)) != 0;
358 entry->SetBoolean(kHasNotificationsField, has_notifications);
359 important_sites_list->Append(std::move(entry));
360 }
361 }
362
363 std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
364 result->SetBoolean(kFlagEnabledField, important_sites_flag_enabled);
365 result->Set(kImportantSitesField, std::move(important_sites_list));
366
367 ResolveJavascriptCallback(*callback_id, *result);
368 }
369
251 void ClearBrowsingDataHandler::HandleInitialize(const base::ListValue* args) { 370 void ClearBrowsingDataHandler::HandleInitialize(const base::ListValue* args) {
252 AllowJavascript(); 371 AllowJavascript();
253 const base::Value* callback_id; 372 const base::Value* callback_id;
254 CHECK(args->Get(0, &callback_id)); 373 CHECK(args->Get(0, &callback_id));
255 374
256 // Needed because WebUI doesn't handle renderer crashes. See crbug.com/610450. 375 // Needed because WebUI doesn't handle renderer crashes. See crbug.com/610450.
257 task_observer_.reset(); 376 task_observer_.reset();
258 377
259 UpdateSyncState(); 378 UpdateSyncState();
260 RefreshHistoryNotice(); 379 RefreshHistoryNotice();
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 444
326 void ClearBrowsingDataHandler::UpdateCounterText( 445 void ClearBrowsingDataHandler::UpdateCounterText(
327 std::unique_ptr<browsing_data::BrowsingDataCounter::Result> result) { 446 std::unique_ptr<browsing_data::BrowsingDataCounter::Result> result) {
328 CallJavascriptFunction( 447 CallJavascriptFunction(
329 "cr.webUIListenerCallback", base::Value("update-counter-text"), 448 "cr.webUIListenerCallback", base::Value("update-counter-text"),
330 base::Value(result->source()->GetPrefName()), 449 base::Value(result->source()->GetPrefName()),
331 base::Value(GetChromeCounterTextFromResult(result.get()))); 450 base::Value(GetChromeCounterTextFromResult(result.get())));
332 } 451 }
333 452
334 } // namespace settings 453 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698