Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/resources/settings/controls/important_site_checkbox.js

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: change ImportantSite type declaration Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview
7 * `important-site-checkbox` is a checkbox that displays an important site.
michaelpg 2017/05/03 21:48:06 again, try to explain what an important site is or
dullweber 2017/05/04 08:31:08 Done.
8 */
9 Polymer({
10 is: 'important-site-checkbox',
11
12 properties: {
13 /** @type {ImportantSite} */
14 site: Object,
15
16 disabled: {type: Boolean, value: false},
17 },
18
19 /**
20 * Returns the icon to use for a given site.
21 * @param {string} site The url of the site to fetch the icon for.
michaelpg 2017/05/03 21:48:06 site => url to match parameter (is closure running
dullweber 2017/05/04 08:31:09 fixed and I added it to the closure compilation
22 * @return {string} The background-image style with the favicon.
23 * @private
24 */
25 siteIcon_: function(url) {
26 return 'background-image: ' + cr.icon.getFavicon(url);
27 },
28
michaelpg 2017/05/03 21:48:06 nit: remove blank line
dullweber 2017/05/04 08:31:09 Done.
29 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698