Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_important_sites_util.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: add using declaration Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/browsing_data/browsing_data_important_sites_util.h"
6
7 #include "content/public/browser/browsing_data_filter_builder.h"
8
9 namespace browsing_data_important_sites_util {
10
11 void Remove(int remove_mask,
12 int origin_mask,
13 browsing_data::TimePeriod time_period,
14 std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder,
15 BrowsingDataRemover* remover,
16 BrowsingDataRemover::Observer* observer) {
17 int filterable_mask =
18 remove_mask &
19 ChromeBrowsingDataRemoverDelegate::IMPORTANT_SITES_DATA_TYPES;
20 int nonfilterable_mask =
21 remove_mask &
22 ~ChromeBrowsingDataRemoverDelegate::IMPORTANT_SITES_DATA_TYPES;
23
24 browsing_data::RecordDeletionForPeriod(time_period);
25
26 if (filterable_mask) {
27 remover->RemoveWithFilterAndReply(
28 browsing_data::CalculateBeginDeleteTime(time_period),
29 browsing_data::CalculateEndDeleteTime(time_period), filterable_mask,
30 origin_mask, std::move(filter_builder), observer);
31 } else {
32 // Make sure |observer| doesn't wait for the filtered task.
dschuyler 2017/04/07 00:02:05 Nit: the comment here and on line 42 seem unnecess
dullweber 2017/04/07 09:39:21 Done.
33 observer->OnBrowsingDataRemoverDone();
34 }
35
36 if (nonfilterable_mask) {
37 remover->RemoveAndReply(
38 browsing_data::CalculateBeginDeleteTime(time_period),
39 browsing_data::CalculateEndDeleteTime(time_period), nonfilterable_mask,
40 origin_mask, observer);
41 } else {
42 // Make sure |observer| doesn't wait for the non-filtered task.
43 observer->OnBrowsingDataRemoverDone();
44 }
45 }
46
47 } // namespace browsing_data_important_sites_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698