Implement important sites dialog for desktop.

chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-clear-browsing-data-dialog' allows the user to delete
  * browsing data that has been cached by Chromium.
  */
 Polymer({
   is: 'settings-clear-browsing-data-dialog',
 
   behaviors: [WebUIListenerBehavior],
 
   properties: {
     /**
      * Preferences state.
      */
     prefs: {
       type: Object,
       notify: true,
     },
 
     /**
+     * State of this dialog, either "clearBrowsingData" or "importantSites".
+     * @private
+     */
+    dialogState_: {
+      type: String,
+      value: "clearBrowsingData",
+    },
+
+    /**
      * Results of browsing data counters, keyed by the suffix of
      * the corresponding data type deletion preference, as reported
      * by the C++ side.
      * @private {!Object<string>}
      */
     counters_: {
       type: Object,
       value: {
         // Will be filled as results are reported.
       }
@@ skipping 19 matching lines @@
     clearingInProgress_: {
       type: Boolean,
       value: false,
     },
 
     /** @private */
     showHistoryDeletionDialog_: {
       type: Boolean,
       value: false,
     },
+
+    /** @private {!Array<ImportantSite>} */
+    importantSites_: {
+      type: Array,
+      value: [],
+    },
+
+    /** @private */
+    importantSitesDialogDisabled_: {
+      type: Boolean,
+      value: false,
+    },
+
   },
 
   /** @private {settings.ClearBrowsingDataBrowserProxy} */
   browserProxy_: null,
 
   /** @override */
   ready: function() {
     this.$.clearFrom.menuOptions = this.clearFromOptions_;
     this.addWebUIListener(
         'update-footer',
         this.updateFooter_.bind(this));
     this.addWebUIListener(
         'update-counter-text',
         this.updateCounterText_.bind(this));
   },
 
   /** @override */
   attached: function() {
     this.browserProxy_ =
         settings.ClearBrowsingDataBrowserProxyImpl.getInstance();
     this.browserProxy_.initialize().then(function() {
       this.$.dialog.showModal();
+      this.browserProxy_.fetchImportantSites().then(
+          this.receiveImportantSites.bind(this));
     }.bind(this));
   },
 
   /**
+   * @param {!ImportantSitesResponse} result
+   * @private
+   */
+  receiveImportantSites: function(result) {
+    this.importantSitesDialogDisabled_ = result.dialogDisabled;
+    this.set('importantSites_', result.importantSites);
+  },
+
+  /**
    * Updates the footer to show only those sentences that are relevant to this
    * user.
    * @param {boolean} syncing Whether the user is syncing data.
    * @param {boolean} otherFormsOfBrowsingHistory Whether the user has other
    *     forms of browsing history in their account.
    * @private
    */
   updateFooter_: function(syncing, otherFormsOfBrowsingHistory) {
     this.$.googleFooter.hidden = !otherFormsOfBrowsingHistory;
     this.$.syncedDataSentence.hidden = !syncing;
     this.$.dialog.classList.add('fully-rendered');
   },
 
   /**
    * Updates the text of a browsing data counter corresponding to the given
    * preference.
    * @param {string} prefName Browsing data type deletion preference.
    * @param {string} text The text with which to update the counter
    * @private
    */
   updateCounterText_: function(prefName, text) {
     // Data type deletion preferences are named "browser.clear_data.<datatype>".
     // Strip the common prefix, i.e. use only "<datatype>".
     var matches = prefName.match(/^browser\.clear_data\.(\w+)$/);
     this.set('counters_.' + assert(matches[1]), text);
   },
 
   /**
+   * @param {string} currentDialogState The current dialog state.
+   * @return {boolean} Whether this is the clear browsing data dialog.
+   * @private
+   */
+  isClearBrowsingDataDialog_: function(currentDialogState) {
+    return currentDialogState == "clearBrowsingData";
+  },
+
+  /**
+   * @param {string} currentDialogState The current dialog state.
+   * @return {boolean} Whether this is the important sites dialog.
+   * @private
+   */
+  isImportantSitesDialog_: function(currentDialogState) {
+    return currentDialogState == "importantSites";
+  },
+
+  /** @private */
+  shouldShowImportantSites_: function() {
+    if (this.isImportantSitesDialog_(this.dialogState_)) return false;
+    if (this.importantSitesDialogDisabled_) return false;
+    if (!this.$.cookiesCheckbox.checked && !this.$.cacheCheckbox.checked) {
+      return false;
+    }
+    var haveImportantSites = this.importantSites_.length > 0;

[dmurph, 2017/03/13 22:26:38]

Can you capture the dialog being disabled here? In the Java code we should be
reporting a 'false' here if the dialog is disabled, but in this code it looks
like we would report that as 'true'.

(we do this by just keeping the length at 0:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...)

Actually - it looks like you handle this in the cpp side anyways? I guess I was
confused because the disabled setting was checked again on line 192

[dullweber, 2017/03/14 10:32:04]

This function will return false in line 170 when the dialog is disabled. I also
don't return important sites from cpp if it is disabled. I agree that the check
in line 192 is redundant. Should it be removed?

+    chrome.send('metricsHandler:recordBooleanHistogram',
+        ["History.ClearBrowsingData.ImportantDialogShown", haveImportantSites]);
+    return haveImportantSites;
+  },
+
+  /**
    * Handles the tap on the Clear Data button.
    * @private
    */
   onClearBrowsingDataTap_: function() {
+    if (this.shouldShowImportantSites_()) {
+      this.dialogState_ = "importantSites";
+      return;
+    }
+
     this.clearingInProgress_ = true;
 
-    this.browserProxy_.clearBrowsingData().then(
+    var importantSites = this.importantSitesDialogDisabled_
+        ? [] : this.importantSites_;
+
+    this.browserProxy_.clearBrowsingData(importantSites).then(
       /**
        * @param {boolean} shouldShowNotice Whether we should show the notice
        *     about other forms of browsing history before closing the dialog.
        */
       function(shouldShowNotice) {
         this.clearingInProgress_ = false;
         this.showHistoryDeletionDialog_ = shouldShowNotice;
 
         if (!shouldShowNotice)
           this.$.dialog.close();
       }.bind(this));
   },
 
   /** @private */
   onCancelTap_: function() {
     this.$.dialog.cancel();
   },
 
   /**
    * Handles the closing of the notice about other forms of browsing history.
    * @private
    */
   onHistoryDeletionDialogClose_: function() {
     this.showHistoryDeletionDialog_ = false;
     this.$.dialog.close();
   }
 });