Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/android/chrome_feature_list.cc

Issue 2716333002: Implement important sites dialog for desktop. (Closed)
Patch Set: log histogram when important sites is shown Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/chrome_feature_list.h" 5 #include "chrome/browser/android/chrome_feature_list.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 namespace { 31 namespace {
32 32
33 // Array of features exposed through the Java ChromeFeatureList API. Entries in 33 // Array of features exposed through the Java ChromeFeatureList API. Entries in
34 // this array may either refer to features defined in the header of this file or 34 // this array may either refer to features defined in the header of this file or
35 // in other locations in the code base (e.g. chrome/, components/, etc). 35 // in other locations in the code base (e.g. chrome/, components/, etc).
36 const base::Feature* kFeaturesExposedToJava[] = { 36 const base::Feature* kFeaturesExposedToJava[] = {
37 &autofill::kAutofillScanCardholderName, 37 &autofill::kAutofillScanCardholderName,
38 &features::kConsistentOmniboxGeolocation, 38 &features::kConsistentOmniboxGeolocation,
39 &features::kCredentialManagementAPI, 39 &features::kCredentialManagementAPI,
40 &features::kImportantSitesInCBD,
40 &features::kNativeAndroidHistoryManager, 41 &features::kNativeAndroidHistoryManager,
41 &features::kServiceWorkerPaymentApps, 42 &features::kServiceWorkerPaymentApps,
42 &features::kSimplifiedFullscreenUI, 43 &features::kSimplifiedFullscreenUI,
43 &features::kVrShell, 44 &features::kVrShell,
44 &features::kWebPayments, 45 &features::kWebPayments,
45 &kAndroidPayIntegrationV1, 46 &kAndroidPayIntegrationV1,
46 &kAndroidPayIntegrationV2, 47 &kAndroidPayIntegrationV2,
47 &kAndroidPaymentApps, 48 &kAndroidPaymentApps,
48 &kAndroidPaymentAppsFilter, 49 &kAndroidPaymentAppsFilter,
49 &kCCTExternalLinkHandling, 50 &kCCTExternalLinkHandling,
50 &kCCTPostMessageAPI, 51 &kCCTPostMessageAPI,
51 &kChromeHomeFeature, 52 &kChromeHomeFeature,
52 &kContextualSearchSingleActions, 53 &kContextualSearchSingleActions,
53 &kContextualSearchUrlActions, 54 &kContextualSearchUrlActions,
54 &kCustomFeedbackUi, 55 &kCustomFeedbackUi,
55 &kImportantSitesInCBD,
56 &kImprovedA2HS, 56 &kImprovedA2HS,
57 &kNoCreditCardAbort, 57 &kNoCreditCardAbort,
58 &kNTPCondensedLayoutFeature, 58 &kNTPCondensedLayoutFeature,
59 &kNTPCondensedTileLayoutFeature, 59 &kNTPCondensedTileLayoutFeature,
60 &kNTPFakeOmniboxTextFeature, 60 &kNTPFakeOmniboxTextFeature,
61 &kNTPLaunchAfterInactivity, 61 &kNTPLaunchAfterInactivity,
62 &kNTPOfflinePagesFeature, 62 &kNTPOfflinePagesFeature,
63 &NTPShowGoogleGInOmniboxFeature, 63 &NTPShowGoogleGInOmniboxFeature,
64 &kPhysicalWebFeature, 64 &kPhysicalWebFeature,
65 &kPhysicalWebSharing, 65 &kPhysicalWebSharing,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 119
120 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi", 120 const base::Feature kCustomFeedbackUi{"CustomFeedbackUi",
121 base::FEATURE_DISABLED_BY_DEFAULT}; 121 base::FEATURE_DISABLED_BY_DEFAULT};
122 122
123 const base::Feature kDownloadAutoResumptionThrottling{ 123 const base::Feature kDownloadAutoResumptionThrottling{
124 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT}; 124 "DownloadAutoResumptionThrottling", base::FEATURE_ENABLED_BY_DEFAULT};
125 125
126 const base::Feature kContextualSearchUrlActions{ 126 const base::Feature kContextualSearchUrlActions{
127 "ContextualSearchUrlActions", base::FEATURE_DISABLED_BY_DEFAULT}; 127 "ContextualSearchUrlActions", base::FEATURE_DISABLED_BY_DEFAULT};
128 128
129 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
130 base::FEATURE_DISABLED_BY_DEFAULT};
131
132 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut 129 // Makes "Add to Home screen" in the app menu generate an APK for the shortcut
133 // URL which opens Chrome in fullscreen. 130 // URL which opens Chrome in fullscreen.
134 const base::Feature kImprovedA2HS{"ImprovedA2HS", 131 const base::Feature kImprovedA2HS{"ImprovedA2HS",
135 base::FEATURE_DISABLED_BY_DEFAULT}; 132 base::FEATURE_DISABLED_BY_DEFAULT};
136 133
137 const base::Feature kNoCreditCardAbort{"NoCreditCardAbort", 134 const base::Feature kNoCreditCardAbort{"NoCreditCardAbort",
138 base::FEATURE_DISABLED_BY_DEFAULT}; 135 base::FEATURE_DISABLED_BY_DEFAULT};
139 136
140 const base::Feature kNTPCondensedLayoutFeature{ 137 const base::Feature kNTPCondensedLayoutFeature{
141 "NTPCondensedLayout", base::FEATURE_DISABLED_BY_DEFAULT}; 138 "NTPCondensedLayout", base::FEATURE_DISABLED_BY_DEFAULT};
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name, 240 return base::GetFieldTrialParamByFeatureAsBool(*feature, param_name,
244 jdefault_value); 241 jdefault_value);
245 } 242 }
246 243
247 bool RegisterChromeFeatureListJni(JNIEnv* env) { 244 bool RegisterChromeFeatureListJni(JNIEnv* env) {
248 return RegisterNativesImpl(env); 245 return RegisterNativesImpl(env);
249 } 246 }
250 247
251 } // namespace android 248 } // namespace android
252 } // namespace chrome 249 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698