Implement important sites dialog for desktop.

chrome/browser/browsing_data/browsing_data_important_sites_util.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browsing_data/browsing_data_important_sites_util.h"
+
+#include "content/public/browser/browsing_data_filter_builder.h"
+
+namespace browsing_data_important_sites_util {
+
+void Remove(int remove_mask,
+            int origin_mask,
+            browsing_data::TimePeriod time_period,
+            const std::vector<std::string>& excluded_domains,
+            BrowsingDataRemover* remover,
+            BrowsingDataRemover::Observer* observer) {
+  int filterable_mask =
+      remove_mask & BrowsingDataRemover::IMPORTANT_SITES_DATATYPES;
+  int nonfilterable_mask =
+      remove_mask & ~BrowsingDataRemover::IMPORTANT_SITES_DATATYPES;
+
+  std::unique_ptr<content::BrowsingDataFilterBuilder> filter_builder(

[dmurph, 2017/03/06 21:16:47]

Unless I'm contradicting something, can you bring the filter builder back out of
this method extraction? You can test if anything is in there by calling
"IsEmptyBlacklist()" if you need.

Let's us be more generic in the exclusion args. But again, if I've been
contradicted, don't worry about it.

[dullweber, 2017/03/07 12:24:34]

I moved it back. I think the relevant part that should be extracted is the logic
about the separate calls to the BrowsingDataRemover.

+      content::BrowsingDataFilterBuilder::Create(
+          content::BrowsingDataFilterBuilder::BLACKLIST));
+  for (const std::string& domain : excluded_domains) {
+    filter_builder->AddRegisterableDomain(domain);
+  }
+
+  browsing_data::RecordDeletionForPeriod(time_period);
+
+  if (filterable_mask) {
+    remover->RemoveWithFilterAndReply(
+        browsing_data::CalculateBeginDeleteTime(time_period),
+        browsing_data::CalculateEndDeleteTime(time_period), filterable_mask,
+        origin_mask, std::move(filter_builder), observer);
+  } else {
+    // Make sure |observer| doesn't wait for the filtered task.
+    observer->OnBrowsingDataRemoverDone();
+  }
+
+  if (nonfilterable_mask) {
+    remover->RemoveAndReply(
+        browsing_data::CalculateBeginDeleteTime(time_period),
+        browsing_data::CalculateEndDeleteTime(time_period), nonfilterable_mask,
+        origin_mask, observer);
+  } else {
+    // Make sure |observer| doesn't wait for the non-filtered task.
+    observer->OnBrowsingDataRemoverDone();
+  }
+}
+
+}  // namespace browsing_data_important_sites_util