chrome/browser/browsing_data/browsing_data_remover_util.h - Issue 2716333002: Implement important sites dialog for desktop.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_util.h

Issue 2716333002: Implement important sites dialog for desktop. (Closed)

Patch Set: extract deletion logic to util class Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_UTIL_H_

	6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_UTIL_H_

	7

	8 #include <vector>

	9

	10 #include "chrome/browser/browsing_data/browsing_data_remover.h"

	11 #include "components/browsing_data/core/browsing_data_utils.h"

	12

	13 class BrowsingDataRemoverUtil {
	msramek 2017/03/06 15:37:34 The style guide discourages pure static classes an The style guide discourages pure static classes and suggests custom namespaces instead. https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a... We probably shouldn't use the browsing_data namespace here, as that implies components/browsing_data; it seems that a common practice in these situations is to use a namespace equal to the filename. dullweber 2017/03/13 14:53:23 Done. Show quoted text On 2017/03/06 15:37:34, msramek wrote: > The style guide discourages pure static classes and suggests custom namespaces > instead. > > https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a... > > We probably shouldn't use the browsing_data namespace here, as that implies > components/browsing_data; it seems that a common practice in these situations is > to use a namespace equal to the filename. Done.
	14 public:

	15 // Deletes the types protected by Important Sites with a filter, and the rest

	16 // completely. The observer will be called twice.

	17 static void Remove(int remove_mask,

	18 int origin_mask,

	19 browsing_data::TimePeriod time_period,

	20 const std::vector<std::string>& excluded_domains,

	21 BrowsingDataRemover* remover,

	22 BrowsingDataRemover::Observer* observer);

	23 };

	24

	25 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_UTIL_H_

OLD	NEW